Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

list: slotted list-items that are not direct children of a list should get a drag handle #9662

Closed
2 of 6 tasks
driskull opened this issue Jun 21, 2024 · 4 comments
Closed
2 of 6 tasks

list: slotted list-items that are not direct children of a list should get a drag handle #9662

driskull opened this issue Jun 21, 2024 · 4 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. estimate - 2 Small fix or update, may require updates to tests.
Milestone
2024-06-25 - Jun ...

Comments

@driskull
Copy link
Member

Check existing issues

Actual Behavior

list-item's slotted inside a div within a list do not get drag handles when dragging is enabled

Expected Behavior

Both of the lists in the sample codepen should work the same.

Reproduction Sample

https://codepen.io/driskull/pen/eYaMPdB?editors=1000

Reproduction Steps

  1. Open codepen
  2. Notice how the first list is missing drag handles on some items
  3. Notice how the second list has drag handles on some items
  4. These lists should be equal

Reproduction Version

2.9.0

Relevant Info

No response

Regression?

No response

Priority impact

impact - p1 - need for current milestone

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Maps SDK for JavaScript
@driskull driskull added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jun 21, 2024
@driskull driskull self-assigned this Jun 21, 2024
@github-actions github-actions bot added ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. calcite-components Issues specific to the @esri/calcite-components package. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone labels Jun 21, 2024
@driskull driskull added 2 - in development Issues that are actively being worked on. estimate - 2 Small fix or update, may require updates to tests. and removed 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone calcite-components Issues specific to the @esri/calcite-components package. labels Jun 21, 2024
@driskull driskull added this to the 2024-06-25 - Jun Release milestone Jun 21, 2024
@driskull driskull mentioned this issue Jun 21, 2024
Merged
driskull added a commit that referenced this issue Jun 21, 2024
@driskull
fix(list): enable dragging on list items contained within a list that…
5010ef9 
… supports dragEnabled (#9660)

**Related Issue:** #9662

## Summary

I'd like to get this one in to support work in Maps SDK.

A limitation of the Maquette VDOM is that it creates a "div" for every
new widget. So in order to make a list item as a widget it needs to
support `calcite-list-item`s wrapped in divs.

- Support dragging on list-items that are not direct children of a list
- Add tests
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Jun 21, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned driskull Jun 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@DitwanP
Copy link
Contributor

DitwanP commented Jun 21, 2024

@driskull This is what I'm seeing when testing locally, the drag handles show up but I'm unable to actually drag them. Are you getting the same results?

Screen.Recording.2024-06-21.at.12.52.00.PM.mov

@driskull
Copy link
Member Author

Ah, dang. Well I solved part of the issue. I'll need to investigate to see if we can get dragging to work in the above scenario.

At first glance, it seems like Sortable has to have direct children but I'll investigate more.

Can we open a new issue for the dragging part @DitwanP?

@DitwanP
Copy link
Contributor

DitwanP commented Jun 21, 2024 •
edited
Loading

Technically the issue of showing drag handles has been resolved so closing this out, will be creating a new issue for fixing the dragging functionality.

New issue: #9663

@DitwanP DitwanP closed this as completed Jun 21, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. estimate - 2 Small fix or update, may require updates to tests.
Projects
None yet
Milestone
2024-06-25 - Jun Release
Development

No branches or pull requests
3 participants
@driskull @geospatialem @DitwanP