Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(list-item): improve list item outline #9675

Merged
merged 3 commits into from
Jun 24, 2024
Merged

fix(list-item): improve list item outline #9675

merged 3 commits into from
Jun 24, 2024

Conversation

josercarcamo
Copy link
Contributor

Related Issue: #7538

Summary

Improves outline around list item.

@josercarcamo josercarcamo requested a review from a team as a code owner June 24, 2024 18:50
@josercarcamo josercarcamo changed the title Josercarcamo/7538 improve outline v2 fix(list-item): Improves list item outline Jun 24, 2024
@jcfranco jcfranco changed the title fix(list-item): Improves list item outline fix(list-item): improve list item outline Jun 24, 2024
@jcfranco jcfranco added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Jun 24, 2024
jcfranco
jcfranco approved these changes Jun 24, 2024
View reviewed changes
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM! +@macandcheese for additional review.

@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Jun 24, 2024
@josercarcamo josercarcamo added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Jun 24, 2024
macandcheese
macandcheese approved these changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@macandcheese macandcheese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎆

@josercarcamo josercarcamo merged commit b8c2fff into dev Jun 24, 2024
12 checks passed
@josercarcamo josercarcamo deleted the josercarcamo/7538-improve-outline-v2 branch June 24, 2024 20:45
@github-actions github-actions bot added this to the 2024-06-25 - Jun Release milestone Jun 24, 2024
@benelan benelan added autorelease: tagged Pull requests created by release-please that were merged and deployed and removed autorelease: tagged Pull requests created by release-please that were merged and deployed labels Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcfranco jcfranco jcfranco approved these changes

@macandcheese macandcheese macandcheese approved these changes

Assignees

@josercarcamo josercarcamo

Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Milestone
2024-06-25 - Jun Release
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@josercarcamo @jcfranco @macandcheese @benelan