Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(radio-group): add setFocus method #364

Merged
merged 1 commit into from Mar 6, 2020
Merged

feat(radio-group): add setFocus method #364

merged 1 commit into from Mar 6, 2020

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Mar 6, 2020 •
edited

Related issue: #74

Adds CalciteRadioGroup#setFocus() 馃憗馃憮:camera: 馃摳

@jcfranco jcfranco added the enhancement Issues tied to a new feature or request. label Mar 6, 2020
@jcfranco jcfranco added this to the 馃敤 v1-beta.21 milestone Mar 6, 2020
@jcfranco jcfranco self-assigned this Mar 6, 2020
macandcheese
macandcheese approved these changes Mar 6, 2020
View reviewed changes
Copy link
Contributor

@macandcheese macandcheese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

driskull
driskull approved these changes Mar 6, 2020
View reviewed changes
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

We've established a pattern for using setFocus for different parts of a component if that is necessary for one of yours.

https://github.com/Esri/calcite-app-components/blob/356e3996610cd4f638fff5534f06cbf179719a1c/src/components/calcite-panel/calcite-panel.tsx#L139

@jcfranco jcfranco merged commit 69943b9 into master Mar 6, 2020
@jcfranco jcfranco deleted the jcfranco/74-add-focus-to-radio-group branch March 6, 2020 23:17
@jcfranco jcfranco mentioned this pull request Mar 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macandcheese macandcheese macandcheese approved these changes

@driskull driskull driskull approved these changes

@paulcpederson paulcpederson Awaiting requested review from paulcpederson

Assignees

@jcfranco jcfranco

Labels
enhancement Issues tied to a new feature or request.
Projects
None yet
Milestone
v1.0.0-beta.21
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jcfranco @driskull @macandcheese