Update conventions for theming and unique ids #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickarlt
requested review from
paulcpederson,
driskull,
ffaubry,
macandcheese and
pemberdom
|
🥇 |
macandcheese
approved these changes
Jun 18, 2019
driskull
approved these changes
Jun 18, 2019
paulcpederson
approved these changes
Jun 18, 2019
alisonailea
pushed a commit
that referenced
this pull request
Aug 29, 2023
chore: updating my branch with the latest from main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some additional info to conventions that @ffaubry and @pemberdom were asking about in Teams regarding theming both for single elements and all elements on the page. It also adds a theming demo to
<calcite-tabs>This also adds new conventions based around what I did for the auto generated id fields in
<calcite-tabs>which I was discussing with @driskull and @macandcheese.