fix(alert): Correctly dismiss after hovering #6228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bug
|
Should also resolve #6132 |
alisonailea
approved these changes
Jan 4, 2023
macandcheese
added
pr ready for visual snapshots
|
Surprisingly the related change in Chromatic for Alert seems to be unrelated - exists on other PR https://www.chromatic.com/build?appId=6266d45509d7eb004aa254fb&number=663 - if someone could approve :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #6222
Summary
This should fix the problem described in the issue - it now handles multiple "hover on and off" events and, at least in local testing, seems to handle large queues that may be present pretty well. The events used were changed to fire less often, and there's an accrued timer of hover time that now is used to determine remaining duration before dismissal.
The watcher for changing the duration now resets it to the default, so unless a user interacts with the alert, it may display for a bit longer. Although, I can't think of a use case where this would be changed while an alert is open, we do use it in demos, and we could refactor this code to better support that if needed.
Screen.Recording.2023-01-03.at.8.34.08.PM.mov