fix(block): Ensure description has correct line-height #6723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bug
macandcheese
added
the
pr ready for visual snapshots
alisonailea
approved these changes
Apr 4, 2023
jcfranco
added
pr ready for visual snapshots
|
@SkyeSeitz @ashetland - please check these Chromatic changes - https://www.chromatic.com/pullrequest?appId=6266d45509d7eb004aa254fb&number=6723&activeElementId=comparison-test-key-636c55c5698b291127b1a60d-1200&view=changes - this update adjusts by a few pixels. Based on the original issue, this is an expected change with this update, but want to confirm. |
|
Merging as Chromatic changes have been approved - note - there are slight px adjustment as a result. |
github-actions
bot
added this to the 2023 April Priorities - No breaking changes milestone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #6443
Summary
The previous Tailwind text declaration wasn't setting a line-height, meaning the description could unintentionally inherit line-height from a parent container. This wasn't affecting the
collapsibleblock as the rendered button has additional style set that prevents the issue.