Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(action-bar): add "actions-end" slot (deprecates "bottom-actions") #7435

Merged
merged 6 commits into from
Aug 8, 2023
Merged

feat(action-bar): add "actions-end" slot (deprecates "bottom-actions") #7435

merged 6 commits into from
Aug 8, 2023

Conversation

driskull
Copy link
Member

@driskull driskull commented Aug 3, 2023 •
edited
Loading

Related Issue: #6517

Summary

  • Add "actions-end" slot (deprecates "bottom-actions")
  • Update tests
  • Update stories
  • Update demos
  • Update usage
  • Update CSS

@github-actions github-actions bot added the enhancement Issues tied to a new feature or request. label Aug 3, 2023
@driskull driskull added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Aug 3, 2023
@driskull driskull marked this pull request as ready for review August 3, 2023 22:57
@driskull driskull requested a review from a team as a code owner August 3, 2023 22:57
@driskull driskull added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Aug 4, 2023
@driskull driskull removed the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Aug 4, 2023
@driskull driskull mentioned this pull request Aug 4, 2023
Merged
jcfranco
jcfranco approved these changes Aug 7, 2023
View reviewed changes
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@jcfranco
Copy link
Member

jcfranco commented Aug 7, 2023

Since this is using feat, I think the message should be rephrased as add "actions-end" slot (deprecates "bottom-actions") (or similar) to emphasize the feature vs the deprecation.

@driskull driskull changed the title feat(action-bar): Deprecate "bottom-actions" slot in favor of new "actions-end" slot feat(action-bar): add "actions-end" slot (deprecates "bottom-actions") Aug 7, 2023
@driskull driskull added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Aug 8, 2023
@driskull driskull merged commit 1bf14ff into main Aug 8, 2023
15 checks passed
@driskull driskull deleted the dris0000/action-bar-actions-end branch August 8, 2023 16:15
@github-actions github-actions bot added this to the 2023 August Priorities milestone Aug 8, 2023
@calcite-admin calcite-admin mentioned this pull request Aug 8, 2023
Merged
benelan pushed a commit that referenced this pull request Aug 15, 2023
@calcite-admin @github-actions
chore: release main (#7485)
124df0a 
🤖 I have created a release *beep* *boop*
---


<details><summary>@esri/calcite-components: 1.6.0</summary>

##
[1.6.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@1.5.1...@esri/calcite-components@1.6.0)
(2023-08-15)


### Features

* **action-bar:** Add "actions-end" slot (deprecates "bottom-actions")
([#7435](#7435))
([1bf14ff](1bf14ff))


### Bug Fixes

* **block:** Defaults the status icon to `scale=s`
([#7503](#7503))
([e1aee99](e1aee99))
* **button,card,fab,inline-editable:** Provides context to AT users when
loading
([#7257](#7257))
([df33eda](df33eda))
* **chip-group:** Add existence checks
([#7487](#7487))
([33225a7](33225a7))
* **combobox:** Prevents navigation list with Space key
([#7505](#7505))
([58e2ff2](58e2ff2))
* **panel:** Fix heading border when only text content is slotted
([#7491](#7491))
([7704400](7704400))
* **progress:** Completes animation for `dir='rtl'`
([#7511](#7511))
([c5d6ada](c5d6ada))
* **scrim:** Handle slotted children correctly
([#7477](#7477))
([c5ce008](c5ce008))
* **scrim:** Render text content inside scrim
([#7509](#7509))
([643ce5d](643ce5d))
* **slider:** Rerender ticks when prop is modified
([#7439](#7439))
([20058a9](20058a9))
* **tree:** Selects all child items when selection-mode is set to
ancestors
([#7518](#7518))
([f1eef84](f1eef84))
</details>

<details><summary>@esri/calcite-components-react: 1.6.0</summary>

##
[1.6.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@1.5.1...@esri/calcite-components-react@1.6.0)
(2023-08-15)


### Bug Fixes

* Prevent vitetest/ssr errors due to defining components on the server
([#7521](#7521))
([046672e](046672e))


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from ^1.6.0-next.7 to ^1.6.0
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
driskull added a commit that referenced this pull request Aug 15, 2023
@driskull
refactor(action-bar, action-pad, action-group): Remove usage of getSl…
4336635 
…otted utility (#7464)

**Related Issue:** #6059

## Summary

- Depends on #7435
benelan pushed a commit that referenced this pull request Aug 16, 2023
@calcite-admin @github-actions @benelan
chore: release main (#7485)
ff8ba0f 
🤖 I have created a release *beep* *boop*
---


<details><summary>@esri/calcite-components: 1.6.0</summary>

##
[1.6.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@1.5.1...@esri/calcite-components@1.6.0)
(2023-08-15)


### Features

* **action-bar:** Add "actions-end" slot (deprecates "bottom-actions")
([#7435](#7435))
([1bf14ff](1bf14ff))


### Bug Fixes

* **block:** Defaults the status icon to `scale=s`
([#7503](#7503))
([e1aee99](e1aee99))
* **button,card,fab,inline-editable:** Provides context to AT users when
loading
([#7257](#7257))
([df33eda](df33eda))
* **chip-group:** Add existence checks
([#7487](#7487))
([33225a7](33225a7))
* **combobox:** Prevents navigation list with Space key
([#7505](#7505))
([58e2ff2](58e2ff2))
* **panel:** Fix heading border when only text content is slotted
([#7491](#7491))
([7704400](7704400))
* **progress:** Completes animation for `dir='rtl'`
([#7511](#7511))
([c5d6ada](c5d6ada))
* **scrim:** Handle slotted children correctly
([#7477](#7477))
([c5ce008](c5ce008))
* **scrim:** Render text content inside scrim
([#7509](#7509))
([643ce5d](643ce5d))
* **slider:** Rerender ticks when prop is modified
([#7439](#7439))
([20058a9](20058a9))
* **tree:** Selects all child items when selection-mode is set to
ancestors
([#7518](#7518))
([f1eef84](f1eef84))
</details>

<details><summary>@esri/calcite-components-react: 1.6.0</summary>

##
[1.6.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@1.5.1...@esri/calcite-components-react@1.6.0)
(2023-08-15)


### Bug Fixes

* Prevent vitetest/ssr errors due to defining components on the server
([#7521](#7521))
([046672e](046672e))


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from ^1.6.0-next.7 to ^1.6.0
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
benelan pushed a commit that referenced this pull request Aug 16, 2023
@driskull @benelan
refactor(action-bar, action-pad, action-group): Remove usage of getSl…
563536a 
…otted utility (#7464)

**Related Issue:** #6059

## Summary

- Depends on #7435
@jcfranco jcfranco mentioned this pull request Jun 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcfranco jcfranco jcfranco approved these changes

Assignees

@driskull driskull

Labels
enhancement Issues tied to a new feature or request. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Milestone
1.6.0 - Low risk issues only
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@driskull @jcfranco @geospatialem