Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(panel): fix collapse action title and reverse icon direction #7927

Merged
merged 2 commits into from
Oct 5, 2023
Merged

fix(panel): fix collapse action title and reverse icon direction #7927

merged 2 commits into from
Oct 5, 2023

Conversation

driskull
Copy link
Member

@driskull driskull commented Oct 3, 2023 •
edited

Related Issue: #7930

Summary

  • invert expand/collapse title attribute value.
  • reverse icon direction.

@driskull driskull added the low risk Issues with low risk for consideration in low risk milestones label Oct 3, 2023
@driskull driskull self-assigned this Oct 3, 2023
@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Oct 3, 2023
@driskull driskull changed the title fix(panel): fix expand/collapse title. @driskull fix(panel): fix collapse action title and reverse icon direction Oct 3, 2023
@driskull driskull changed the title @driskull fix(panel): fix collapse action title and reverse icon direction fix(panel): fix collapse action title and reverse icon direction Oct 3, 2023
@driskull driskull marked this pull request as ready for review October 3, 2023 21:17
@driskull driskull requested a review from a team as a code owner October 3, 2023 21:17
@jcfranco jcfranco added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Oct 4, 2023
jcfranco
jcfranco approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥

@jcfranco
Copy link
Member

jcfranco commented Oct 5, 2023 •
edited

+@ashetland for screenshot review 👀👍

@driskull driskull merged commit 5f620f8 into main Oct 5, 2023
19 checks passed
@driskull driskull deleted the dris0000/panel-collapse-action-title-fix branch October 5, 2023 18:09
@calcite-admin calcite-admin mentioned this pull request Oct 5, 2023
Merged
geospatialem pushed a commit that referenced this pull request Oct 6, 2023
@calcite-admin @github-actions
chore: release main (#7945)
c15eb96 
🤖 I have created a release *beep* *boop*
---


<details><summary>@esri/calcite-components: 1.9.1</summary>

##
[1.9.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@1.9.0...@esri/calcite-components@1.9.1)
(2023-10-05)


### Bug Fixes

* **combobox:** Fix issue causing value to be cleared when selecting an
item (Windows + trackpad)
([#7954](#7954))
([557d658](557d658))
* **input-time-zone:** Fix handling of unknown and cityless time zones
from offset display mode
([#7947](#7947))
([75e0302](75e0302))
* **panel:** Fix collapse action title and reverse icon direction
([#7927](#7927))
([5f620f8](5f620f8))
</details>

<details><summary>@esri/calcite-components-react: 1.9.1</summary>

##
[1.9.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@1.9.0...@esri/calcite-components-react@1.9.1)
(2023-10-05)


### Miscellaneous Chores

* **@esri/calcite-components-react:** Synchronize undefined versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from ^1.9.1-next.1 to ^1.9.1
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
benelan added a commit that referenced this pull request Oct 11, 2023
@benelan
Merge remote-tracking branch 'origin/main' into astump/chore-add-configs
0fe870a 
* origin/main: (83 commits)
  chore: add design tokens to monorepo (#7948)
  test(input-time-zone): restore common tests (#7963)
  chore: release next
  fix(input-time-zone): fix error caused by time zone group filtering (#7971)
  chore: release next
  fix(table): Improve scrollbar display (#7967)
  build: bump timezone-groups (#7962)
  chore: release next
  fix(flow-item): update collapsed property when collapse button is clicked (#7960)
  chore: release main (#7945)
  chore: release next
  fix(input-time-zone): fix handling of unknown and cityless time zones from offset display mode (#7947)
  fix(combobox): fix issue causing value to be cleared when selecting an item (Windows + trackpad) (#7954)
  chore(deps): update calcite-ui-icons to 3.24.7 (#7949)
  test(flow-item, panel): add tests for internal property. (#7931)
  chore: release next
  fix(panel): fix collapse action title and reverse icon direction (#7927)
  chore: update issue template labels to support workflows (#7938)
  build(deps): bump timezone-groups (#7933)
  build(deps): update dependency @esri/calcite-ui-icons to v3.24.6 (#7925)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcfranco jcfranco jcfranco approved these changes

Assignees

@driskull driskull

Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. low risk Issues with low risk for consideration in low risk milestones pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Milestone
2023 October Priorities - Maintenance...
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@driskull @jcfranco