refactor: extract icon scale adjustment logic into utility function #7935
Conversation
packages/calcite-components/src/components/accordion-item/accordion-item.tsx
Outdated
Show resolved
Hide resolved
packages/calcite-components/src/utils/iconScaleAdjuster.spec.ts
Outdated
Show resolved
Hide resolved
jcfranco
changed the title
|
I've gone ahead and updated the PR title to follow conventional commits (per our contributing guidelines). |
|
Hi @jcfranco Please check my new commits and let me know if everything is fine now. Thanks for your guidance. |
packages/calcite-components/src/utils/iconScaleAdjuster.spec.ts
Outdated
Show resolved
Hide resolved
|
Hi @jcfranco i am just checking if everything is ok on the latest changes. If I need to modify anything please let me know. Thanks |
|
@alhridoy It looks like the PR still shows merge conflicts. Once these are resolved, we can take it from there. Thanks again for helping out with this! |
|
I went ahead and adopted this PR (#7973) to get both E2E and screenshot tests running. Once checks are ✅, we should be good to install for the October release. |
|
@alhridoy The adopted one (containing your original commits), yes. |
…7973) # Adopted #7935 cc @alhridoy --- **Related Issue:** #7765 ## Summary This pull request extracts the logic for adjusting internal icon scales into a separate utility function. This function is now used across all components, making the code DRYer and easier to maintain. ## Changes - Created a new utility function `adjustIconScale` in `iconScaleAdjuster.ts`. - Replaced inline logic for adjusting icon scales with calls to `adjustIconScale` in all relevant components. ## Testing - All unit tests pass. - Manual testing in the browser confirms that icons still display correctly at all scales. This change stems from issue #7755 and is expected to make the codebase easier to maintain by reducing repetition of this logic. --------- Co-authored-by: Al-Iqram Elahee <hridoy@Al-Iqrams-MacBook-Pro.local>
|
Hi @jcfranco Great! You welcome. Thanks a lot for guidances. |
Related Issue: #7765
Summary
This pull request extracts the logic for adjusting internal icon scales into a separate utility function. This function is now used across all components, making the code DRYer and easier to maintain.
Changes
adjustIconScaleiniconScaleAdjuster.ts.adjustIconScalein all relevant components.Testing
This change stems from issue #7755 and is expected to make the codebase easier to maintain by reducing repetition of this logic.