Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inline-editable): add component tokens #8596

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Jan 12, 2024

Related Issue: #7180

Summary

Adds the following component tokens:

  • --calcite-inline-editable-background-color
  • --calcite-inline-editable-size

Note: this removes disabled styling for the editing button wrapper as it was not being applied (no border style set).

@jcfranco jcfranco added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Jan 12, 2024
@jcfranco jcfranco added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Jan 16, 2024
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Jan 24, 2024
@jcfranco
Copy link
Member Author

Closing in favor of updated PR: #8788.

@jcfranco jcfranco closed this Feb 20, 2024
@jcfranco jcfranco deleted the jcfranco/7180-add-component-tokens-for-inline-editable branch February 20, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr ready for visual snapshots Adding this label will run visual snapshot testing. Stale Issues or pull requests that have not had recent activity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants