Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(select): add component tokens #8599

Merged
merged 15 commits into from
Mar 5, 2024
Merged

feat(select): add component tokens #8599

merged 15 commits into from
Mar 5, 2024

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Jan 13, 2024 •
edited
Loading

Related Issue: #7180

Summary

Adds the following component tokens (CSS props):

  • --calcite-select-background-color
  • --calcite-select-background-color-hover
  • --calcite-select-border-color
  • --calcite-select-text-color

and deprecates the following:

  • --calcite-select-font-size
  • --calcite-select-spacing

Note: --calcite-select-space-inline was removed from the doc as it is not defined nor used

@jcfranco jcfranco mentioned this pull request Jan 13, 2024
Open
7 tasks
@jcfranco jcfranco added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Jan 13, 2024
@jcfranco jcfranco added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Jan 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Jan 25, 2024
alisonailea
alisonailea requested changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@alisonailea alisonailea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. I think the tokens can be simplified and font-size and space made internal

packages/calcite-components/src/components/select/select.scss Outdated Show resolved Hide resolved
packages/calcite-components/src/components/select/select.scss Outdated Show resolved Hide resolved
@jcfranco jcfranco marked this pull request as ready for review February 20, 2024 20:26
@jcfranco jcfranco requested a review from a team as a code owner February 20, 2024 20:26
@jcfranco jcfranco added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. Stale Issues or pull requests that have not had recent activity. labels Feb 21, 2024
@jcfranco jcfranco added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Feb 21, 2024
@jcfranco jcfranco added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Feb 21, 2024
@alisonailea alisonailea self-requested a review February 22, 2024 17:22
alisonailea
alisonailea requested changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@alisonailea alisonailea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be something off with the VRT. Looks like the font size changed?

@alisonailea
Copy link
Contributor

Do e2e tests pass for you? I'm noticing an issue with the select > form associated tests.

@jcfranco jcfranco added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Feb 28, 2024
@jcfranco jcfranco added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Feb 28, 2024
@jcfranco
Copy link
Member Author

Do e2e tests pass for you? I'm noticing an issue with the select > form associated tests.

FYI, looking into this one. 👀

@jcfranco jcfranco added skip visual snapshots Pull requests that do not need visual regression testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Feb 29, 2024
@jcfranco
Copy link
Member Author

@alisonailea E2E tests are ✅ now.

@jcfranco jcfranco added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed skip visual snapshots Pull requests that do not need visual regression testing. labels Feb 29, 2024
@jcfranco jcfranco merged commit 0a3d3be into epic/7180-component-tokens Mar 5, 2024
4 checks passed
@jcfranco jcfranco deleted the jcfranco/7180-add-component-tokens-for-select branch March 5, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alisonailea alisonailea alisonailea approved these changes

@macandcheese macandcheese Awaiting requested review from macandcheese

Assignees
No one assigned
Labels
pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jcfranco @alisonailea @macandcheese