Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(action-menu): skip unstable tests #8999

Merged
merged 2 commits into from
Mar 26, 2024
Merged

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Mar 26, 2024

Related Issue: #9000

Summary

 Summary of all failing tests
@esri/calcite-components:test: FAIL src/components/action-menu/action-menu.e2e.ts (19.748 s)
@esri/calcite-components:test:   ● calcite-action-menu › Keyboard navigation › should click the active action when clicked and close the menu
@esri/calcite-components:test: 
@esri/calcite-components:test:     expect(received).toBe(expected) // Object.is equality
@esri/calcite-components:test: 
@esri/calcite-components:test:     Expected: false
@esri/calcite-components:test:     Received: true
@esri/calcite-components:test: 
@esri/calcite-components:test:       523 |       await page.$eval("calcite-action", (el: HTMLCalciteActionElement) => el.click());
@esri/calcite-components:test:       524 |
@esri/calcite-components:test:     > 525 |       expect(await actionMenu.getProperty("open")).toBe(false);
@esri/calcite-components:test:           |                                                    ^
@esri/calcite-components:test:       526 |       expect(clickSpy).toHaveReceivedEventTimes(1);
@esri/calcite-components:test:       527 |     });
@esri/calcite-components:test:       528 |   });
@esri/calcite-components:test: 
@esri/calcite-components:test:       at Object.<anonymous> (src/components/action-menu/action-menu.e2e.ts:525:52)
@esri/calcite-components:test: FAIL src/components/action-menu/action-menu.e2e.ts (18.704 s)
@esri/calcite-components:test:   ● calcite-action-menu › Keyboard navigation › should click the active action on Enter key and close the menu
@esri/calcite-components:test: 
@esri/calcite-components:test:     expect(received).toBe(expected) // Object.is equality
@esri/calcite-components:test: 
@esri/calcite-components:test:     Expected: false
@esri/calcite-components:test:     Received: true
@esri/calcite-components:test: 
@esri/calcite-components:test:       487 |       await page.waitForChanges();
@esri/calcite-components:test:       488 |
@esri/calcite-components:test:     > 489 |       expect(await actionMenu.getProperty("open")).toBe(false);
@esri/calcite-components:test:           |                                                    ^
@esri/calcite-components:test:       490 |       expect(clickSpy).toHaveReceivedEventTimes(1);
@esri/calcite-components:test:       491 |     });
@esri/calcite-components:test:       492 |
@esri/calcite-components:test: 
@esri/calcite-components:test:       at Object.<anonymous> (src/components/action-menu/action-menu.e2e.ts:489:52)

@jcfranco jcfranco requested a review from a team as a code owner March 26, 2024 18:27
@jcfranco jcfranco added the skip visual snapshots Pull requests that do not need visual regression testing. label Mar 26, 2024
@github-actions github-actions bot added the testing Issues related to automated or manual testing. label Mar 26, 2024
@jcfranco jcfranco changed the title test(action-menu): skip unstable test test(action-menu): skip unstable tests Mar 26, 2024
@jcfranco jcfranco merged commit ee72777 into main Mar 26, 2024
14 checks passed
@jcfranco jcfranco deleted the jcfranco/skip-unstable-test branch March 26, 2024 22:46
@github-actions github-actions bot added this to the 2024-03-26 - Mar Release milestone Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip visual snapshots Pull requests that do not need visual regression testing. testing Issues related to automated or manual testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants