Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: adds support to test issue template priority status #9192

Merged
merged 2 commits into from Apr 27, 2024
Merged

ci: adds support to test issue template priority status #9192

merged 2 commits into from Apr 27, 2024

Conversation

geospatialem
Copy link
Member

@geospatialem geospatialem commented Apr 25, 2024 •
edited by jcfranco

Related Issue: #9191

Summary

Enables a priority option in the test issue template, which will add a priority label upon creation.

@github-actions github-actions bot added the chore Issues with changes that don't modify src or test files. label Apr 25, 2024
@geospatialem geospatialem added the skip visual snapshots Pull requests that do not need visual regression testing. label Apr 25, 2024
@geospatialem
Copy link
Member Author

geospatialem commented Apr 25, 2024 •
edited

WRT this comment:

Also updates the addPriorityLabel.js to exclude a new label that includes a priority.

Not tied to the above, it is a bit extraneous with regards to the change, so can omit it from the PR - if it is better without the change, both from a code readability standpoint and outcome.

edit: reverted the above ☝🏻 since it seems extraneous.

benelan
benelan approved these changes Apr 27, 2024
View reviewed changes
Copy link
Member

@benelan benelan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jcfranco jcfranco merged commit a5edfa4 into main Apr 27, 2024
12 checks passed
@jcfranco jcfranco deleted the geospatialem/9191-chore-tooling-priority branch April 27, 2024 04:23
@github-actions github-actions bot added this to the 2024-04-30 - Apr Release milestone Apr 27, 2024
benelan added a commit that referenced this pull request Apr 29, 2024
@benelan
Merge remote-tracking branch 'origin/main' into benelan/add-invalid-c…
8377b54 
…ustom-event

* origin/main:
  fix(chip-group): Improve programmatic Chip selection behavior (#9213)
  test(input-date-picker): add test for no longer closing date-picker when using arrow and page keys. (#9097)
  build(deps): update actions/setup-node action to v4 (#9143)
  ci: adds support to test issue template priority status (#9192)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benelan benelan benelan approved these changes

@jcfranco jcfranco Awaiting requested review from jcfranco jcfranco is a code owner

@driskull driskull Awaiting requested review from driskull driskull is a code owner

Assignees

@geospatialem geospatialem

Labels
chore Issues with changes that don't modify src or test files. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Milestone
2024-04-30 - Apr Release
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@geospatialem @benelan @jcfranco