Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(input, input-number, input-text): restore autofocus, enter-key-mode and input-mode attributes (#9245) #9306

Merged
merged 2 commits into from
May 10, 2024
Merged

fix(input, input-number, input-text): restore autofocus, enter-key-mode and input-mode attributes (#9245) #9306

merged 2 commits into from
May 10, 2024

Commits on May 10, 2024

  1. fix(input, input-number, input-text): restore autofocus, `enter-key… 

    …-mode` and `input-mode` attributes (#9245)

**Related Issue:** #9235

## Summary

This fixes the following issues introduced by #9123 when component props
that shadowed global attributes were removed:

* the kebab-cased attribute names of those props would no longer work
(namely, `enter-key-mode`, `input-mode`)
* `autofocus` was missing from component types as Stencil does not
include it in the base `HTMLAttribute` type (see
ionic-team/stencil#5726).
    @jcfranco
    jcfranco committed May 10, 2024
    Configuration menu
    Copy the full SHA
    2542f4e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'hotfix' into jcfranco/fix-regression-from-global-attr-c… 

    …hange
    @benelan
    benelan committed May 10, 2024
    Configuration menu
    Copy the full SHA
    5ee8ff0 View commit details
    Browse the repository at this point in the history