Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(panel, flow-item): add footer-start and footer-end slots #9374

Merged
merged 27 commits into from
Jun 25, 2024
Merged

feat(panel, flow-item): add footer-start and footer-end slots #9374

merged 27 commits into from
Jun 25, 2024

Conversation

Elijbet
Copy link
Contributor

@Elijbet Elijbet commented May 20, 2024 •
edited
Loading

Related Issue: #8981

Summary

  • Add footer-start and footer-end slots.
  • Provide horizontal gap setting within footer-start & footer-end slots according to scale.
  • Provide vertical gap setting within existing footer slot according to scale.

@github-actions github-actions bot added the enhancement Issues tied to a new feature or request. label May 20, 2024
@Elijbet Elijbet added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label May 20, 2024
@Elijbet Elijbet added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels May 20, 2024
@Elijbet Elijbet marked this pull request as ready for review May 21, 2024 00:00
@Elijbet Elijbet requested a review from a team as a code owner May 21, 2024 00:00
@Elijbet Elijbet marked this pull request as draft May 21, 2024 00:24
@Elijbet Elijbet added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels May 21, 2024
@Elijbet Elijbet marked this pull request as ready for review May 21, 2024 04:52
@github-actions GitHub Actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label May 30, 2024
@github-actions github-actions bot removed the Stale Issues or pull requests that have not had recent activity. label Jun 8, 2024
@benelan benelan changed the base branch from main to dev June 10, 2024 09:12
@Elijbet Elijbet marked this pull request as draft June 18, 2024 16:37
@Elijbet Elijbet added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Jun 21, 2024
@Elijbet
gap for stacked footers
5ad04a0
@Elijbet
fix:slotchange
791e77c 
event bubbling from the subslots and messing with the logic
@Elijbet Elijbet added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Jun 22, 2024
@Elijbet Elijbet added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Jun 22, 2024
@Elijbet Elijbet added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Jun 23, 2024
@Elijbet Elijbet added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Jun 24, 2024
@Elijbet Elijbet added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Jun 24, 2024
@Elijbet Elijbet added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Jun 24, 2024
jcfranco
jcfranco reviewed Jun 24, 2024
View reviewed changes
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

packages/calcite-components/src/components/flow-item/flow-item.stories.ts
@@ -65,15 +65,17 @@ const contentHTML = html`
`;

const footerHTML = html`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not critical for this PR, but let's try to rename this to better match its usage. This is named as footer, but it has HTML with start/end footer slot content. Applies to panel stories.

jcfranco
jcfranco approved these changes Jun 24, 2024
View reviewed changes
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

driskull
driskull approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Elijbet Elijbet merged commit 3def3ea into dev Jun 25, 2024
12 checks passed
@Elijbet Elijbet deleted the elijbet/8981-panel-refactor-footer branch June 25, 2024 00:14
@github-actions github-actions bot added this to the 2024-06-25 - Jun Release milestone Jun 25, 2024
benelan added a commit that referenced this pull request Jun 25, 2024
@benelan
Merge remote-tracking branch 'origin/dev' into benelan/8065-input-tim…
49a992a 
…e-min-max

* origin/dev:
  chore: release next
  feat(input-time-zone): add `offsetStyle` prop (#9426)
  chore: release next
  feat(panel, flow-item): add `footer-start` and `footer-end` slots (#9374)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcfranco jcfranco jcfranco approved these changes

@driskull driskull driskull approved these changes

Assignees

@Elijbet Elijbet

Labels
enhancement Issues tied to a new feature or request. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Milestone
2024-06-25 - Jun Release
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Elijbet @jcfranco @driskull