fix(combobox): fix error that occurs when a click is emitted when the component is appended to the DOM #9380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… component is appended to the DOM (#9373) **Related Issue:** #9321 ## Summary This fixes an issue where references to internal elements were undefined in the window-level click handler. This would happen because the window click handler was added when the component was connected, but before its internals were rendered.
github-actions
bot
added
the
bug
benelan
changed the title
benelan
added
the
pr ready for visual snapshots
jcfranco
approved these changes
May 21, 2024
Merged
benelan
added a commit
that referenced
this pull request
May 24, 2024
…x-constraint * origin/main: (37 commits) build(deps): update dependency @stencil/core to v4.18.2 (#9266) refactor(stepper-item): drop unnecessary transitions (#9327) docs(contributing): add commit message formatting details (#9389) docs: update component READMEs (#9328) build: update browserslist db (#9263) chore: release next fix(tree): allow single select only and add indicator (#9405) chore: release next feat(split-button): Make dividers consistent (#9402) chore: release next feat(stepper, stepper-item): add separate change events to stepper and items (deprecates `calciteStepperItemChange` on the parent) (#9351) chore(tree): fix multiple selection-mode values set in slotted dropdown-groups (#9378) fix(dropdown-group): title scale with dropdown scale (#9360) chore: release next fix(tree): allow deselection in single selectionMode (#9363) chore: Update placeholder images in stories and demos (#9395) chore: use local placeholder image in html files (#9392) chore: release next chore: release hotfix (#9382) fix(combobox): fix error that occurs when a click is emitted when the component is appended to the DOM (#9380) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #9321
Summary
This fixes an issue where references to internal elements were undefined
in the window-level click handler. This would happen because the window
click handler was added when the component was connected, but before its
internals were rendered.