fix: set the correct Sortable parent when within a shadowRoot #9532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bug
driskull
changed the title
|
@jcfranco can we do this one for June release? |
jcfranco
approved these changes
Jun 20, 2024
There was a problem hiding this comment.
LGTM!
It looks like the related issue has been closed and verified already. Should we reopen and bounce back or do we need to create a new issue? +@geospatialem for guidance.
Yeah, we did fix the issue but we didn't do it the correct way according to Sortablejs. So we can reopen or create a new issue. |
Ah, good to know - I'll re-open the issue. |
driskull
added
the
skip visual snapshots
benelan
added a commit
that referenced
this pull request
Jun 24, 2024
…rovements * origin/dev: build(deps): update typescript-eslint monorepo to v7.13.1 (#9657) docs: update component READMEs (#9668) chore: release next chore: minor git tooling tweaks (#9664) feat(combobox): add `filterText` prop (#9654) chore: release next feat(list): add filterProps property to specify which properties to filter against (#9622) chore: release next fix(list): enable dragging on list items contained within a list that supports dragEnabled (#9660) test(filter): add coverage for empty filter text (#9655) chore: release next fix: set the correct Sortable parent when within a shadowRoot (#9532) fix(combobox): allow arrow selection of entered text (#9629)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #9521
Summary