fix(list, list-item, list-item-group): add e2e themed tests #9616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcfranco
approved these changes
Jun 18, 2024
| * @prop --calcite-list-item-group-background-color: Specifies the background color of the component. | ||
| * @prop --calcite-list-item-group-border-color: Specifies the border color of the component. | ||
| * @prop --calcite-list-item-heading-text-color: Specifies the text color of the component's heading. | ||
| * @prop --calcite-list-item-group-background-color: Specifies the background color of the component. Will fallback to --calcite-list-background-color. |
There was a problem hiding this comment.
Do we need to list the fallback CSS Props in the doc? Also, it looks like the documented fallback props are not used.
There was a problem hiding this comment.
We do not. Thanks for the catch!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #7180
Summary
Made sure components were UTD with /dev to reduce merge conflict churn
Updates component tokens
Update e2e themed tests