Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(handle): avoid mutable warnings from t9n props #9636

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

jcfranco
Copy link
Member

Related Issue: N/A

Summary

Marks t9n internal props as mutable to avoid warning debug messages. Doc was also updated for consistency.

@jcfranco jcfranco requested a review from a team as a code owner June 19, 2024 19:10
@github-actions github-actions bot added the chore Issues with changes that don't modify src or test files. label Jun 19, 2024
@jcfranco jcfranco added the skip visual snapshots Pull requests that do not need visual regression testing. label Jun 19, 2024
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 💯

@jcfranco jcfranco merged commit c725986 into dev Jun 20, 2024
9 checks passed
@jcfranco jcfranco deleted the jcfranco/fix-invalid-t9n-handle-message-warnings branch June 20, 2024 18:38
@github-actions github-actions bot added this to the 2024-06-25 - Jun Release milestone Jun 20, 2024
@benelan benelan added autorelease: tagged Pull requests created by release-please that were merged and deployed and removed autorelease: tagged Pull requests created by release-please that were merged and deployed labels Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issues with changes that don't modify src or test files. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants