-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(slider): add token theme tests #9665
base: epic/7180-component-tokens
Are you sure you want to change the base?
test(slider): add token theme tests #9665
Conversation
Additional notes: I was unsuccessful getting this extra test to pass, and I'm unsure why:
This is an attempt to test that the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because we are using the same color to test multiple values its possible to get a false positive on tests. Make sure you are stopping the test just before verification and confirming the tokens are correctly applied. Or check in storybook.
Should we randomize the color being used in each test run? |
Related Issue: #7180
Summary
This PR adds token theme tests for
calcite-slider
.