Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(block): use icon value as key instead of class for consistency #9689

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

jcfranco
Copy link
Member

Related Issue: N/A

Summary

✨🧹✨

@jcfranco jcfranco requested a review from a team as a code owner June 25, 2024 22:41
@github-actions github-actions bot added the refactor Issues tied to code that needs to be significantly reworked. label Jun 25, 2024
@jcfranco jcfranco added the skip visual snapshots Pull requests that do not need visual regression testing. label Jun 25, 2024
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔑 👍

@jcfranco jcfranco merged commit f2f3c93 into dev Jun 26, 2024
9 checks passed
@jcfranco jcfranco deleted the jcfranco/use-icon-value-for-key-in-block branch June 26, 2024 21:31
@github-actions github-actions bot added this to the 2024-07-30 - Jul Release milestone Jun 26, 2024
benelan added a commit that referenced this pull request Jun 27, 2024
…anup

* origin/dev:
  chore(linting): enable @typescript-eslint/methd-signature-style for safer types (#9690)
  refactor(block): use icon value as key instead of class for consistency (#9689)
  chore: fix package-lock versioning (#9702)
  test(panel): restore coverage for space between footer start/end slots (#9682)
  test(input-time-zone): tidy up Intl API polyfill/override (#9676)
  fix(angular): resolve empty dist (#9698)
  chore: release main (#9697)
benelan pushed a commit that referenced this pull request Jun 27, 2024
…cy (#9689)

**Related Issue:** N/A

## Summary

✨🧹✨
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Issues tied to code that needs to be significantly reworked. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants