Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for terminology in form documentation #1054

Merged
merged 2 commits into from
Jan 24, 2019
Merged

Fix for terminology in form documentation #1054

merged 2 commits into from
Jan 24, 2019

Conversation

macandcheese
Copy link
Contributor

Fix for #1053

@paulcpederson
Copy link
Member

paulcpederson commented Jan 24, 2019 •
edited
Loading

@macandcheese can you remove the CHANGELOG entry for this. Usually we don't add doc-only changes there as it's just noise for devs expecting library-level changes. (Also 1.2.3 was already released)

Otherwise, looks ✨

@macandcheese
Copy link
Contributor Author

Sure thing, updated 💅

@macandcheese macandcheese mentioned this pull request Jan 24, 2019
Closed
@macandcheese macandcheese merged commit 244b186 into Esri:master Jan 24, 2019
@paulcpederson
Copy link
Member

💯 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulcpederson paulcpederson Awaiting requested review from paulcpederson

@jpeterson jpeterson Awaiting requested review from jpeterson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@macandcheese @paulcpederson