-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/join datasets #411
Fix/join datasets #411
Conversation
4238fbd
to
7f9ac29
Compare
add dataset.ts and joinDatasets() using flattenData and joinData instead of flattenFeatureSets move getChartData to datasets.js as getData() for testing also make it the only export clarify tests
This is why Jest is dumb |
it's still dumb to run tests for browser code in node
Glad you brought that up. I meant to include screenshots and explain the same. I actually had the code to add those, but the only way I could think to do that requires another loop through each value field for each dataset for each row, so I thought the above behavior was sufficient, and it wasn't worth the overhead This morning I had the thought that we could add an option like |
also added more comments
this is a WIP, everything is working, just need to iron out a few wrinkles and squashresolves #406