Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG-000128224 Users are able to utilize the Search function in the CrowdSource Reporter solution, even after disabling the Search tool via the web app configuration. #522

Closed
aparveen opened this issue Dec 2, 2021 · 6 comments
Assignees
Milestone

Comments

@aparveen
Copy link
Contributor

aparveen commented Dec 2, 2021

  • Log into ArcGIS Online and go to your Content section
  • Create an editable hosted feature layer and web map
    • Create > Feature Layer
  • Create a new web application (Content > Create > Configurable Apps)
    • Search/Select the Crowdsource Reporter template > Create the application
  • Go to your Groups in AGOL and create a new group that will be utilized for the application
    • Add the associated items (map/feature service) to the group
  • Configure the application and go to the General section
    • Select the new Group that will be used for the application
  • Go to the Search section, uncheck "Enable Search Tool"
    • Save the application and launch it in a new tab
  • Click the Search icon and search for a city (Redlands, CA)
    • The Esri Word Geocoding Service is still being utilized for the search even though we disabled the Search tool during our configuration
@aparveen aparveen added this to the AGOL 10.1 milestone Dec 2, 2021
@sumitzarkar
Copy link
Contributor

@aparveen

We analyzed this issue and here are our findings:

  • The Reporter app was designed to have the search widget always
  • Initially, App only use to honor the geocode services configured in the organization settings. And, if no geocoders in the org settings it fallbacks to ArcGIS World Geocoding service.
  • With the implementation of Option to configure which geocoders are used in search #265 , We added the functionality to allow user to configure the geocoders to be used in the application.
  • When we checks the checkbox "Enable Search Tool" in the configuration we are not enableing / disabling the search but we are asking application to use the geocoders which are confugured here in the application settings instead of using geocoders form the organization settings.
  • We think the "Enable Search Tool" text is making confusion and it should be updated to say "Use the below configured geocoder settings"
Current Implementation After Updating Strings
image image
  • We think we should only update the strings in the configuration and should not do any changes to the functionality as CSR app was designed to have a search widget always. Also, if we change the behavior to show or hide the search the widget it would have backward compatibility issues and we need to do these changes in the Main map search and Search in Geoform.

Please let us know your thoughts on this.

@sumitzarkar
Copy link
Contributor

@aparveen

Please confirm if we should proceed wihth this string change

image

@aparveen
Copy link
Contributor Author

@skrishn any suggestion on these strings?
image

@skrishn
Copy link
Contributor

skrishn commented Jan 19, 2022

@sumitzarkar
Please use the text below:

( Description section)
Configure the app with locator(s) from your organization to allow users to find location or data in the map, and optionally customize search properties for each locator.

(Text for the checkbox)
Enable to select locator(s)

cc @aparveen

@sumitzarkar
Copy link
Contributor

sumitzarkar commented Jan 20, 2022

@skrishn @aparveen

Dev Checklist

Items ​ Is required​ Status Comments​
Required NLS changes?​ No    
Required Backward compatibility​ No   
Required 508​ No   
Need Sanitize?​ No   

Impact Analysis Report

Impacted Areas Comments
Have Configuration changes?​ Yes
Have Runtime changes?​ No
Impact on RTL No
String Changes Check for strings changes in the configuration panel image

sumitzarkar added a commit to sumitzarkar/crowdsource-reporter that referenced this issue Jan 25, 2022
@aparveen
Copy link
Contributor Author

Verified in qa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants