Pulse Graphic Sample in Kotlin #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no worries, lets just make sure not to 'Squash and merge' after code review is complete. this'll ensure the branch history stays in sync. |
briantwatson
approved these changes
Jul 25, 2017
|
@jgravois, are you suggesting a merge commit instead of squash and merge? |
correct. squashing would substitute 361a7fa (and a merge commit) with a single (new) sha in Esri:master and leave nohe427:master out of sync. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized I messed up here and committed to my master branch. Here is a sample for GeoNet regarding pulsing a graphic in Android.
Can I get someone to review and merge?
@doneill @natas333x2 @gdhakal @andr7430 @esoekianto @nhaney90