Don't increment the target index if the operational layer is invalid … #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…(e.g. a raster or a terrain model) (#289)
JamesMBallard
requested review from
ldanzinger and
michael-tims
and removed request for
ldanzinger
|
Oops, should be assigned to @michael-tims who did the original code review. |
JamesMBallard
pushed a commit
that referenced
this pull request
Jan 23, 2019
* adding v.next branch for 100.4 * updating readme * adding support for mrsid (#286) * Update Linux base PPI for scaleFactor * DSA: (#287) * DSA: Mitigate the GeoElement base class changes. Provide helpers and a wrapper class that provide the now-missing signal on GeoElement. * DSA: In order for the destroyed signal to function correctly, set the parent of the wrapper to be the GeoElement itself. * DSA: push up some code review fixes. * DSA: The namespace isn't needed here. * DSA: Pass the list by const-ref. * Don't increment the target index if the operational layer is invalid (e.g. a raster or a terrain model) (#289) (#290) * Use new SelectionProperties API (#291) * Scale some UI and fix up a layout warning * Fix compiler warnings: (#293) - unused this in lambda captures - unused variables * initial commit adding KML support to DSA (#294) * initial commit adding KML support to DSA * updating icon * updates from code review * fixes from code review part 2 * The path has changed slightly. This is needed for the quick-start steps. * Revert "The path has changed slightly. This is needed for the quick-start steps." * Update DsaController.cpp (#301)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…(e.g. a raster or a terrain model) (#289)
v.next cherry pick of #289
Already approved and merged to master. Just keeping v.next in sync.
@ldanzinger@michael-tims please review.