Skip to content

Commit

Permalink
fix (most) command line deprecations
Browse files Browse the repository at this point in the history
still getting:

DEPRECATION: An addon is trying to access project.nodeModulesPath. This is not a reliable way to discover npm modules. Instead, consider doing: require("resolve").sync(something, { basedir: project.root }). Accessed from:   NPMDependencyVersionChecker (/Users/tom/code/ember-cli-cedar/node_modules/ember-cli-github-pages/node_modules/ember-cli-version-checker/src/npm-dependency-version-checker.js:11:32)

seems to be related to ember-cli/ember-cli-version-checker#48 (comment)

looks like it's:

├─┬ ember-cli-github-pages@0.1.3
│ ├─┬ ember-cli-babel@5.2.4
│ │ └── ember-cli-version-checker@1.3.1  deduped
│ └── ember-cli-version-checker@1.3.1
  • Loading branch information
tomwayson committed Jan 11, 2018
1 parent 2903525 commit 60f340d
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
7 changes: 3 additions & 4 deletions index.js
Expand Up @@ -33,8 +33,8 @@ module.exports = {
included(app) {
this._super.included.apply(this, arguments);
// parse options from ember-cli-build
this.options = app && app.options && app.options.cedar;
this.amChartsOptions = this.options && this.options.amCharts;
const options = app && app.options;
this.amChartsOptions = options && options.cedar && options.cedar.amCharts;
this.hasAmChartsImports = this.amChartsOptions && this.amChartsOptions.imports && this.amChartsOptions.imports.length > 0;
// when bundling scripts, need to also serve the amCharts assets
// that those scripts will dynamically load
Expand All @@ -53,8 +53,7 @@ module.exports = {
treeForVendor (vendorTree) {
// copy cedar dist files to vendor folder
var cedarTree = new Funnel(path.dirname(require.resolve('@esri/cedar/dist/umd/cedar.js')), {
// TODO: other files? source maps etc?
files: ['cedar.js', 'themes/amCharts/calcite.js'],
files: ['cedar.js', 'cedar.js.map', 'themes/amCharts/calcite.js'],
destDir: 'cedar'
});
var treesToMerge = [vendorTree, cedarTree];
Expand Down
2 changes: 1 addition & 1 deletion package.json
Expand Up @@ -38,7 +38,7 @@
"ember-cli": "~2.18.0",
"ember-cli-dependency-checker": "^2.0.0",
"ember-cli-eslint": "^4.2.1",
"ember-cli-github-pages": "0.1.2",
"ember-cli-github-pages": "^0.1.3",
"ember-cli-htmlbars-inline-precompile": "^1.0.0",
"ember-cli-inject-live-reload": "^1.4.1",
"ember-cli-qunit": "^4.1.1",
Expand Down

0 comments on commit 60f340d

Please sign in to comment.