[DNM] Chore/map acceptance test #28
Conversation
tests fail (sometimes) in odd ways:
- `ember t` always seems to pass
- `ember t -s` fails the first run with phantom showing:
Global error: TypeError: undefined is not an object (evaluating '_qunit['default'].config.current.assert') at http://localhost:7357/assets/test-support.js, line 18229
JSHint | unit/services/esri-loader-test.js: global failure
✘ TypeError: undefined is not an object (evaluating '_qunit['default'].config.current.assert')
http://localhost:7357/assets/test-support.js:18229
TypeError: undefined is not an object (evaluating '_qunit['default'].config.current.assert') at http://localhost:7357/assets/test-support.js, line 18229
and chrome showing:
JSHint | unit/services/esri-loader-test.js: global failure (1, 0, 1)
Uncaught TypeError: Cannot read property 'assert' of undefined
- subsequent runs (pressing enter in console, saving a file, reloading chrome) fail consistently in phantom, but sometimes pass in chrome
also handles case where JSAPI is loaded before assertions are run
lot's of issues w/ this as it stands:
- can't run more than one acceptance test (see comments)
- phantom (only, not chrome) fails w/
Global error: Script error. at , line 0
JSHint | unit/services/esri-loader-test.js: global failure
✘ Script error.
:0
Script error. at , line 0
phantom tests still blow up, but pass in Chrome (`ember t -s --launch=Chrome`) also, still have to skip the index acceptance test
… test this code is _very_ ugly, but it works will try to fix this upstream in esri-loader and remove the ugly hacks here
|
As of 0d9bd07 we can run more than one acceptance test. I tried DRYing up the error handling code but was having problems. Besides, I ultimately want to move that code upstream into esri-loader in Esri/esri-loader#28 I'm still seeing the global script error in phantom. I'm going to try moving the |
|
I would have had to re-arrange most of the dummy app to run I configured the tests to run in FF in CI now. Both |
|
@tomwayson I wouldn't worry about phantom. It's a deprecated library and I'd expect most folks to be moving towards headless chrome at this point. |
This PR suffers from the same problems in #27 - we still can't run more than a single acceptance test.In addition, by trying to actually test the map, we now get the following error every time in PhantomJS (but not in Chrome):
NOTE: that error was happening in ad5c133 - when the acceptance test didn't even try to wait for and inspect the map. In other words, the error occurs simply by loading the JSAPI modules, not even using them. Which sucks, b/c it was such a royal PIA to write a test helper to wait for the map to load.
I'm so f'ing over Ember acceptance tests and the JSAPI.