224-bottom-position

[jwasilgeo]

resolves #224

• Suggestions are now shown above the geocoder input element when using the constructor option position: 'bottomleft' or position: 'bottomright'.
• Added a new sample page (see debug/sample-multiple.html) for testing out the changes in this PR.
• Note that this conditional block of code dealing with the control being in either of the top corners still contains the original css calculations to display suggestions under the geocoder input element. https://github.com/Esri/esri-leaflet-geocoder/compare/224-bottom-position#diff-5763e4da84ffa56f56019ee1a0ff7aacR100
• But the next conditional block of code contains the primary new additions that enable the suggestions to be visible above the geocoder input element when it is in the bottom corners.
• Altered 2 other portions of the code to improve upon some unrelated edge cases dealing with user interaction bugs.
  • Resetting this._lastValue when clearing and collapsing after a result https://github.com/Esri/esri-leaflet-geocoder/compare/224-bottom-position#diff-5763e4da84ffa56f56019ee1a0ff7aacR159
  • Avoid geocoding invalid suggestion child elements https://github.com/Esri/esri-leaflet-geocoder/compare/224-bottom-position#diff-5763e4da84ffa56f56019ee1a0ff7aacR233
• Sprinkled a few TODO comments for future work to clean up other small UI bugs.

Please see commit comments for more details, too.

[gavinr]

Looks good to me - nice work!

Can you please open new issues for the two "todo" comments so that they don't get lost in the shuffle