Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

properly pass through api key #278

Merged
merged 4 commits into from Jul 29, 2021
Merged

Conversation

gavinr
Copy link
Contributor

@gavinr gavinr commented Jul 29, 2021

@gavinr gavinr requested a review from jwasilgeo July 29, 2021 13:40
@gavinr gavinr marked this pull request as ready for review July 29, 2021 13:40
@jwasilgeo
Copy link
Contributor

Thanks for the quick changes and fix!

src/Tasks/Geocode.js Outdated Show resolved Hide resolved
@gavinr gavinr merged commit a7982cc into Esri:master Jul 29, 2021
@gavinr gavinr deleted the token-api-key-support branch July 29, 2021 15:29
@jgravois
Copy link
Contributor

if the new endpoint requires auth it'd be nice if the lib logged a warning when it's missing.

👋

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants