Rollup and class #14
Merged
Rollup and class #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed class name
Updated karma config file path Added http-server to devDependencies and add start script
|
you're definitely not the only one running windows. |
| @@ -3,8 +3,8 @@ | |||
| "version": "v2.0.0-beta.1", | |||
There was a problem hiding this comment.
lets get rid of the bower.json version (see: Esri/esri-leaflet#829 for more info)
| "leaflet": "^1.0.0-beta.1", | ||
| "esri-leaflet": "^2.0.0-beta.4", | ||
| "esri-leaflet": "^2.0.0", | ||
| "leaflet": "^1.0.0-rc.3", | ||
| "leaflet.heat": "^0.1.3" |
There was a problem hiding this comment.
can you bump leaflet.heat to "^0.2.0" please?
i just noticed some erratic shifting of the heatmap on pan/zoom with 0.1.3.
|
made a couple more comments, but everything else looks great. thanks so much for the help with this! |
|
the command below works in Git Bash on Windows... "start": "watch \"npm run build\" src | http-server -p 6789 -c-1 -o", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that should do it. Let me know if I missed something.
FYI: Removing babelify seems to have broken the 'npm start' command on Windows cmd. Cmd treats
watch 'npm run build'aswatch 'npm,watch runandwatch build'. Using\"npm run build\"works for that problem, but then Cmd never leaveswatchandhttp-servenever executes.I'm probably the only one using Windows anyway, and I'm looking into a different shell. Cmd is a mess.