fix #1289 and fix #1298 #1301
Merged
fix #1289 and fix #1298 #1301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwasilgeo
approved these changes
Dec 2, 2021
jgravois
pushed a commit
to jgravois/esri-leaflet
that referenced
this pull request
Apr 23, 2022
jgravois
pushed a commit
to jgravois/esri-leaflet
that referenced
this pull request
Apr 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes both #1289 and #1298. Specifically:
_currentSnapshotwhich is a snapshot of all layers the feature layer has on the map was't properly being cleared when the layer went outside the zoom range. This is the root cause of both issues since it is used ineachActiveFeatureand to determine which featureremovefeatureshould fire for.addfeatureevent when previously removed layers were added back to the map.https://github.com/Esri/esri-leaflet/compare/fix-feature-layer-regressions?expand=1#diff-775f68f7ed2cadfe77df5f560b04512990231859cb3e0cfee6a8c79f305eb54aR523
https://github.com/Esri/esri-leaflet/compare/fix-feature-layer-regressions?expand=1#diff-1d3459775056d23611b051bf252a9d1f457744484695c2ac7ada4f0390f0451dR189-R195