Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Travis CI support #271

Merged
merged 3 commits into from Jul 23, 2014
Merged

Add Travis CI support #271

merged 3 commits into from Jul 23, 2014

Conversation

ungoldman
Copy link
Contributor

No description provided.

@ungoldman
Copy link
Contributor Author

Sad 🐼

Looks like there are two timeout issues (timeout of 2000ms exceeded) as well as other more real issues:

PhantomJS 1.9.7 (Linux) L.esri.Layers.FeatureManager should load more features  with a single time field FAILED
    expected spy to have been called with arguments [{
      geometry: { coordinates: [-122.673339, 45.537134], type: "Point" },
      id: 1,
      properties: { Name: "Site 1", OBJECTID: 1, Time: 1388534400000, Type: "Active" },
      type: "Feature"
    }]
    AssertionError: expected spy to have been called with arguments [{
      geometry: { coordinates: [-122.673339, 45.537134], type: "Point" },
      id: 1,
      properties: { Name: "Site 1", OBJECTID: 1, Time: 1388534400000, Type: "Active" },
      type: "Feature"
    }]
        at /home/travis/build/Esri/esri-leaflet/node_modules/chai/chai.js:925
        at /home/travis/build/Esri/esri-leaflet/node_modules/sinon-chai/lib/sinon-chai.js:90
        at /home/travis/build/Esri/esri-leaflet/node_modules/chai/chai.js:3627
        at /home/travis/build/Esri/esri-leaflet/spec/Layers/FeatureLayer/FeatureManagerSpec.js:305
        at callFn (/home/travis/build/Esri/esri-leaflet/node_modules/mocha/mocha.js:4338)
        at /home/travis/build/Esri/esri-leaflet/node_modules/mocha/mocha.js:4331
        at /home/travis/build/Esri/esri-leaflet/node_modules/mocha/mocha.js:4728
        at /home/travis/build/Esri/esri-leaflet/node_modules/mocha/mocha.js:4819
        at next (/home/travis/build/Esri/esri-leaflet/node_modules/mocha/mocha.js:4653)
        at /home/travis/build/Esri/esri-leaflet/node_modules/mocha/mocha.js:4663
        at next (/home/travis/build/Esri/esri-leaflet/node_modules/mocha/mocha.js:4601)
        at /home/travis/build/Esri/esri-leaflet/node_modules/mocha/mocha.js:4625
        at done (/home/travis/build/Esri/esri-leaflet/node_modules/mocha/mocha.js:4300)
        at callFn (/home/travis/build/Esri/esri-leaflet/node_modules/mocha/mocha.js:4343)
        at /home/travis/build/Esri/esri-leaflet/node_modules/mocha/mocha.js:4331
        at next (/home/travis/build/Esri/esri-leaflet/node_modules/mocha/mocha.js:4626)
        at /home/travis/build/Esri/esri-leaflet/node_modules/mocha/mocha.js:4630
        at timeslice (/home/travis/build/Esri/esri-leaflet/node_modules/mocha/mocha.js:5763)

PhantomJS 1.9.7 (Linux) L.esri.Layers.FeatureManager should load more features  with a start and end time field FAILED
    expected spy to have been called with arguments [{
      geometry: { coordinates: [-122.673342, 45.537161], type: "Point" },
      id: 4,
      properties: {
        EndTime: 1389398400000,
        Name: "Site 4",
        OBJECTID: 4,
        StartTime: 1389312000000,
        Type: "Inactive"
      },
      type: "Feature"
    }]
    AssertionError: expected spy to have been called with arguments [{
      geometry: { coordinates: [-122.673342, 45.537161], type: "Point" },
      id: 4,
      properties: {
        EndTime: 1389398400000,
        Name: "Site 4",
        OBJECTID: 4,
        StartTime: 1389312000000,
        Type: "Inactive"
      },
      type: "Feature"
    }]
        at /home/travis/build/Esri/esri-leaflet/node_modules/chai/chai.js:925
        at /home/travis/build/Esri/esri-leaflet/node_modules/sinon-chai/lib/sinon-chai.js:90
        at /home/travis/build/Esri/esri-leaflet/node_modules/chai/chai.js:3627
        at /home/travis/build/Esri/esri-leaflet/spec/Layers/FeatureLayer/FeatureManagerSpec.js:397
        at callFn (/home/travis/build/Esri/esri-leaflet/node_modules/mocha/mocha.js:4338)
        at /home/travis/build/Esri/esri-leaflet/node_modules/mocha/mocha.js:4331
        at /home/travis/build/Esri/esri-leaflet/node_modules/mocha/mocha.js:4728
        at /home/travis/build/Esri/esri-leaflet/node_modules/mocha/mocha.js:4819
        at next (/home/travis/build/Esri/esri-leaflet/node_modules/mocha/mocha.js:4653)
        at /home/travis/build/Esri/esri-leaflet/node_modules/mocha/mocha.js:4663
        at next (/home/travis/build/Esri/esri-leaflet/node_modules/mocha/mocha.js:4601)
        at /home/travis/build/Esri/esri-leaflet/node_modules/mocha/mocha.js:4625
        at done (/home/travis/build/Esri/esri-leaflet/node_modules/mocha/mocha.js:4300)
        at callFn (/home/travis/build/Esri/esri-leaflet/node_modules/mocha/mocha.js:4343)
        at /home/travis/build/Esri/esri-leaflet/node_modules/mocha/mocha.js:4331
        at next (/home/travis/build/Esri/esri-leaflet/node_modules/mocha/mocha.js:4626)
        at /home/travis/build/Esri/esri-leaflet/node_modules/mocha/mocha.js:4630
        at timeslice (/home/travis/build/Esri/esri-leaflet/node_modules/mocha/mocha.js:5763)

PhantomJS 1.9.7 (Linux) L.esri.Tasks.Identify should identify features in a given time range FAILED
    Script error. (:0)

PhantomJS 1.9.7 (Linux) L.esri.Tasks.Query should query features in a given time range FAILED
    AssertionError: Fake XHR onreadystatechange handler threw exception: expected null to deeply equal { Object (type, features) } (/home/travis/build/Esri/esri-leaflet/node_modules/chai/chai.js:925)

@ungoldman ungoldman mentioned this pull request Jun 18, 2014
Closed
@knownasilya
Copy link
Contributor

Is this a travis timeout issue, or phantom?

@patrickarlt
Copy link
Contributor

All these failures look like some variation of the Sinon mocks not responding
.
My guess is that what ever version of Node+Phantom Travis is using is rounding numbers slightly differently then my local machine. We ran into this trying to put Terraformer on Travis as well.

For example here is one of the failing tests https://github.com/Esri/esri-leaflet/blob/master/spec/Layers/FeatureLayer/FeatureManagerSpec.js#L281. If the bbox doesn't get passed exactly like that Sinon wont respond and the test will either timeout because it never finished or you will end up with Fake XHR onreadystatechange handler threw exception because the server never responded.

The solution is to replace the urls in the Sinon mock with regular expressions that will match any diget like https://github.com/Esri/esri-leaflet/blob/master/spec/Layers/DymanicMapLayerSpec.js#L47

@robertd robertd mentioned this pull request Jul 20, 2014
Merged
@ghost ghost mentioned this pull request Jul 21, 2014
Closed
@robertd robertd mentioned this pull request Jul 23, 2014
Closed
@ghost
Copy link

ghost commented Jul 23, 2014

@ngoldman Look at #294 for more details on this Travis CI failing.

@ungoldman
Copy link
Contributor Author

Thanks @rdjurasaj-usgs, rebasing from master after the timezone fix seems to solve the problem.

@patrickarlt I think this is ready to merge.

patrickarlt added a commit that referenced this pull request Jul 23, 2014
@patrickarlt
Merge pull request #271 from ngoldman/master
d3b5cdb 
Add Travis CI support
@patrickarlt patrickarlt merged commit d3b5cdb into Esri:master Jul 23, 2014
@tomwayson
Copy link
Member

this is going to be an awesome addition to the project.

jgravois pushed a commit to jgravois/esri-leaflet that referenced this pull request Apr 23, 2022
@patrickarlt
Merge pull request Esri#271 from ngoldman/master
dd34031 
Add Travis CI support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ungoldman @knownasilya @patrickarlt @tomwayson