-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added sample application for debugging #364
Conversation
<script src="http://cdn.leafletjs.com/leaflet-0.7.3/leaflet.js"></script> | ||
|
||
<!-- Load Esri Leaflet from CDN --> | ||
<!--script src="http://cdn-geoweb.s3.amazonaws.com/esri-leaflet/0.0.1-beta.6/esri-leaflet.js"></script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't actually need this since you are including the files from /src
below.
i've layed down another commit with @patrickarlt 's suggestions. @tomwayson, i've been chewing on yours and have to admit that i'm torn. i really like the idea of setting things up so that developers don't need to worry about accidently including local changes with an unrelated PR, but at the same time i think its more important to make sure things 'just work' out of the box for developers doing all this for the first time. perhaps we could split the difference and leave the original source code and include something like this as well?
does anyone else have an opinion? |
Another idea would be to set up .gitignore to ignore all .html files under the debug folder except sample.html. Then just put a comment block in sample.html instructing devs to make a copy of the file before modifying it to test their code. I think that's a simpler way of accomplishing the same thing. |
added doc type ignore additional .html files in debug folder
b460843
to
20e229e
Compare
that sounds good to me. i made another change based on @tomwayson 's suggestion and squashed everything down. happy to make additional tweaks. |
Looks good to me @jgravois - thanks! |
added sample application for debugging
added sample application for debugging
added a debug folder to the repository with a sample.html file to assist new developers in referencing local, unminified source files.
more sophisticated logic for injecting scripts could be substituted later if desired.