revert #884, withCredentials can be problematic for non IWA services #890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgravois
pushed a commit
to jgravois/esri-leaflet
that referenced
this pull request
Apr 23, 2022
revert Esri#884, withCredentials can be problematic for non IWA services
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
after tagging
v2.0.5i realized that one of the bug fixes resulted in errors when attempting to use CORS to fetch data from non secure ArcGIS Online feature services.http://jsbin.com/wudoxe/edit?html,output
after tracking down a dependable test machine i also learned that the change wasn't even sufficient to get IWA secure dynamic map service images to draw anyway, because setting the
L.imageOverlayconstructor option crossOrigin to true still stripped identifying cookies and resulted in a 401 error from the server.