Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

break src into modules and improve testing #87

Closed
tomwayson opened this issue Feb 7, 2018 · 1 comment · Fixed by #163
Closed

break src into modules and improve testing #87

tomwayson opened this issue Feb 7, 2018 · 1 comment · Fixed by #163

Comments

@tomwayson
Copy link
Member

Expected behavior

  • we can break esri-loader.ts into multiple files/modules (utils.ts) each w/ own test file that imports only the modules it needs to test
  • we can use karma and it's watcher/plugins to run tests w/o having to use external watchers and bundlers
  • tests can be written in TS

Actual behavior

  • utils is included in esri-loader.ts
  • the current test script uses an external watcher to run a production build and then karma each time a file changes
  • tests are written in ES5
@tomwayson
Copy link
Member Author

karma-typescript looks like it should do the job on the testing front.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant