Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

insertCssBefore option to insert esri css before any node using a selector #161

Merged
merged 4 commits into from Mar 25, 2019

Conversation

tomwayson
Copy link
Member

@tomwayson tomwayson commented Mar 25, 2019

  • Describe the proposed changes:

insertCssBefore option lets user insert esri css before any node (like a <style>) using a selector instead of just the nth <link> element. Also loadCss takes this as a second argument instead of overloading the first, which will be an easier API to work with as we tackle issues like #157

This is not a breaking change b/c we haven't released #158 yet

  • Is there an example or test page to demonstrate any new or changed features?

no

  • Does your PR include appropriate tests for source code alterations?

yes

  • If you're adding or changing a public API, did you update the docs Usage sections of the README?

not yet, still thinking about how/when to doc this yes!

  • Provide a reference to any related issue.

#107

also loadCss takes this as a second argument, which will be a better API going forward
@tomwayson tomwayson requested a review from jgravois March 25, 2019 12:52
Copy link
Contributor

@jgravois jgravois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@tomwayson tomwayson changed the title beforeCss option lets user insert css before any node using a selector insertCssBefore option to insert esri css before any node using a selector Mar 25, 2019
@tomwayson tomwayson merged commit 410562c into master Mar 25, 2019
@tomwayson tomwayson deleted the chore/beforeCss branch March 25, 2019 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants