#84 #86 #88 update to newer Chosen lib #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgravois
approved these changes
Apr 15, 2017
| @@ -53,7 +53,7 @@ function redirectIfQuery() { | |||
| var pageName = window.location.toString(), | |||
| delimiterPosition, | |||
| redirectURL = 'https://github.com/Esri?q=', | |||
| topicList = document.getElementById('esri-topic-list').childNodes | |||
| topicList = document.getElementById('esri-topic-list').childNodes, | |||
There was a problem hiding this comment.
is this why we were getting redirects on urls with no search string?
There was a problem hiding this comment.
it seemed to me that we were redirecting with no query even if we received no query, so I changed it to only check if a query was requested
| @@ -1,10 +1,1321 @@ | |||
| // Copyright (c) 2011 Harvest http://getharvest.com | |||
There was a problem hiding this comment.
we could make this PR even redder if we just used a cdn
load chosen plugin from cdn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's try this out and see if this is a better UI. This is the latest version of Chosen, but it's a bit different than what we had. May require more CSS work.