Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Buffer byte order before reading shape type. #121

Merged
merged 1 commit into from
Aug 23, 2016
Merged

Set Buffer byte order before reading shape type. #121

merged 1 commit into from
Aug 23, 2016

Conversation

kjkrum
Copy link
Contributor

@kjkrum kjkrum commented Aug 22, 2016

Set the byte order of shapeBuffer to little endian before reading the shape type. This change addresses the aspect of #118 that is strictly a bug as opposed to a design issue.

Reference: ESRI Shapefile Technical Description. See shape record content tables beginning on page 6.

@stolstov stolstov merged commit cf4d46c into Esri:master Aug 23, 2016
@kjkrum kjkrum deleted the shape-type-byte-order branch September 23, 2016 18:56
@randallwhitman randallwhitman added this to the 2.0.0 milestone Aug 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants