fix: getIncludesAndReferencesQuery accounts for no association group (#…

…1571)
Esri · Jul 1, 2024 · 7f1d64c · 7f1d64c
1 parent ad0dd5b
commit 7f1d64c
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/packages/common/src/associations/internal/getIncludesAndReferencesQuery.ts b/packages/common/src/associations/internal/getIncludesAndReferencesQuery.ts
@@ -28,6 +28,14 @@ export const getIncludesAndReferencesQuery = async (
   context: IArcGISContext
 ): Promise<IQuery> => {
   if (isParent) {
+    /**
+     * 0. exit early if the parent's association group
+     * hasn't been created yet - there can be no associations
+     */
+    if (!getProp(entity, "associations")) {
+      return null;
+    }
+
     /**
      * 1. build query that returns child entities WITH a
      * typeKeyword reference to the parent

diff --git a/packages/common/test/associations/internal/getIncludesAndReferencesQuery.test.ts b/packages/common/test/associations/internal/getIncludesAndReferencesQuery.test.ts
@@ -1,11 +1,21 @@
-import { cloneObject } from "../../../src";
+import { HubEntity, cloneObject } from "../../../src";
 import { IArcGISContext } from "../../../src/ArcGISContext";
 import { getIncludesAndReferencesQuery } from "../../../src/associations/internal/getIncludesAndReferencesQuery";
 import { MOCK_PARENT_ENTITY, MOCK_CHILD_ENTITY } from "../fixtures";
 import * as ItemsModule from "@esri/arcgis-rest-portal";
 
 describe("getIncludesAndReferencesQuery:", () => {
   describe("from the parent entity perspective", () => {
+    it("returns null if the parent's association group hasn't been created yet", async () => {
+      const query = await getIncludesAndReferencesQuery(
+        {} as HubEntity,
+        "project",
+        true,
+        {} as IArcGISContext
+      );
+
+      expect(query).toBeNull();
+    });
     it("returns a valid IQuery to fetch child entities", async () => {
       const query = await getIncludesAndReferencesQuery(
         MOCK_PARENT_ENTITY,