fix(): source link and source title transform

Esri · Jun 28, 2024 · c7dbe9a · c7dbe9a
1 parent 9f8456e
commit c7dbe9a
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/packages/common/src/core/schemas/internal/metrics/editorToMetric.ts b/packages/common/src/core/schemas/internal/metrics/editorToMetric.ts
@@ -87,10 +87,17 @@ export function editorToMetric(
     expressionSet,
     allowExpressionSet,
     statistic,
+    // if we are in dynamic mode and have a link, then we use that link
+    // otherwise we use manually input sourceLink on card config
+    sourceLink:
+      values.type === "dynamic" && sourceLink ? sourceLink : config.sourceLink,
+    sourceTitle:
+      values.type === "dynamic" && sourceTitle
+        ? sourceTitle
+        : config.sourceTitle,
     allowLink:
       values.type === "dynamic" ? config.allowDynamicLink : config.allowLink,
     type: values.type,
-    dynamicMetric,
   };
 
   return { metric, displayConfig };

diff --git a/packages/common/src/core/schemas/internal/metrics/metricToEditor.ts b/packages/common/src/core/schemas/internal/metrics/metricToEditor.ts
@@ -42,8 +42,12 @@ export function metricToEditor(
             expressionSet,
             allowExpressionSet,
             fieldType,
+            sourceLink: displayConfig.sourceLink,
+            sourceTitle: displayConfig.sourceTitle,
           },
           ...editor,
+          sourceLink: undefined,
+          sourceTitle: undefined,
         };
         break;