feat(hub-common): disable categories field and provide notice when no options are available #1561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent()" helper to prevent duplic affects: @esri/hub-common
…categories are available affects: @esri/hub-common
packages/common/src/core/schemas/internal/fetchCategoriesUiSchemaElement.ts
Show resolved
Hide resolved
…otice affects: @esri/hub-common
…modify affected tests affects: @esri/hub-common
… fetchCategoryItems to follow c affects: @esri/hub-common
sonofflynn89
changed the title
…nk instead of inlined type affects: @esri/hub-common
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1561 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 963 966 +3
Lines 17377 17449 +72
Branches 3027 3043 +16
=========================================
+ Hits 17377 17449 +72 ☔ View full report in Codecov by Sentry. |
abp6318
approved these changes
Jun 24, 2024
juliannemarik
approved these changes
Jun 24, 2024
…s should always use 'launch') affects: @esri/hub-common
esri-dcdev-2
pushed a commit
that referenced
this pull request
Jun 24, 2024
# @esri/hub-common [14.150.0](https://github.com/Esri/hub.js/compare/@esri/hub-common@14.149.0...@esri/hub-common@14.150.0) (2024-06-24) ### Features * **hub-common:** disable categories field and provide notice when no options are available ([#1561](#1561)) ([95035c0](95035c0))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of https://devtopia.esri.com/dc/hub/issues/10382
Highlights:
linkconfiguration object toIUiSchemaMessagethat can only be used when rendering noticesUpdated meaningful TSDoc to methods including Parameters and Returns, see Documentation Guide
used semantic commit messages
PR title follows semantic commit format (CRITICAL if the title is not in a semantic format, the release automation will not run!)