Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 10795 10736 project and initiative creation rules updates #1562

Merged

Conversation

vivzhang
Copy link
Contributor

@vivzhang vivzhang commented Jun 21, 2024

  1. Description:

Inline errors in Project and Initiative creation form validation now block next steps

  1. Instructions for testing:

  2. Closes Issues: # (if appropriate)
    10736
    10795

  3. Updated meaningful TSDoc to methods including Parameters and Returns, see Documentation Guide

  4. used semantic commit messages

  5. PR title follows semantic commit format (CRITICAL if the title is not in a semantic format, the release automation will not run!)

  6. updated peerDependencies as needed. CRITICAL our automated release system can not be counted on to update peerDependencies so we must do it manually in our PRs when needed. See the updating peerDependencies section of the release instructions for more details.

@vivzhang vivzhang changed the title B/10795 10736 project and initiative creation rules updates fix: 10795 10736 project and initiative creation rules updates Jun 21, 2024
affects: @esri/hub-common
…ates' of https://github.com/Esri/hub.js into b/10795-10736-project-and-initiative-creation-rules-updates
Copy link
Contributor

@juliannemarik juliannemarik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@vivzhang vivzhang merged commit 409edc5 into master Jun 28, 2024
5 checks passed
@vivzhang vivzhang deleted the b/10795-10736-project-and-initiative-creation-rules-updates branch June 28, 2024 15:23
esri-dcdev-2 pushed a commit that referenced this pull request Jun 28, 2024
## @esri/hub-common [14.152.2](https://github.com/Esri/hub.js/compare/@esri/hub-common@14.152.1...@esri/hub-common@14.152.2) (2024-06-28)

### Bug Fixes

* 10795 10736 project and initiative creation rules updates ([#1562](#1562)) ([409edc5](409edc5))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants