Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add embed types/interfaces #1585

Merged
merged 7 commits into from
Jul 12, 2024
Merged

Conversation

juliannemarik
Copy link
Contributor

10885

Description:

Scaffolds a new HubEmbed type for use within the entity class system as well as our frontend view/configuration components

  1. Updated meaningful TSDoc to methods including Parameters and Returns, see Documentation Guide
  2. used semantic commit messages
  3. PR title follows semantic commit format (CRITICAL if the title is not in a semantic format, the release automation will not run!)
  4. updated peerDependencies as needed. CRITICAL our automated release system can not be counted on to update peerDependencies so we must do it manually in our PRs when needed. See the updating peerDependencies section of the release instructions for more details.

Copy link
Contributor

@vivzhang vivzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Member

@dbouwman dbouwman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to start, but just wondering how the array of embeds lands in the view, and to consider that when we lay down these interfaces. I suspect we can just add something to the IHubEmbedBase down the line, but if there's more we can add now, lets do that.

Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (69001c6) to head (4c24214).
Report is 18 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##            master     #1585    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          967       973     +6     
  Lines        17438     17561   +123     
  Branches      3038      3072    +34     
==========================================
+ Hits         17438     17561   +123     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juliannemarik juliannemarik merged commit 0529404 into master Jul 12, 2024
7 checks passed
@juliannemarik juliannemarik deleted the feat/10885-embed-data-model branch July 12, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants