-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add embed types/interfaces #1585
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine to start, but just wondering how the array of embeds lands in the view, and to consider that when we lay down these interfaces. I suspect we can just add something to the IHubEmbedBase
down the line, but if there's more we can add now, lets do that.
613bd64
to
e75bedd
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1585 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 967 973 +6
Lines 17438 17561 +123
Branches 3038 3072 +34
==========================================
+ Hits 17438 17561 +123 ☔ View full report in Codecov by Sentry. |
10885
Description:
Scaffolds a new
HubEmbed
type for use within the entity class system as well as our frontend view/configuration componentspeerDependencies
as needed. CRITICAL our automated release system can not be counted on to updatepeerDependencies
so we must do it manually in our PRs when needed. See the updating peerDependencies section of the release instructions for more details.