Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The military style for 2525B change 2 is not found in Pro Install #371

Closed
jmccausland opened this issue Apr 25, 2019 · 6 comments
Closed

Comments

@jmccausland
Copy link
Contributor

@BobBooth When selecting 2525B change 2 as the military style I get the following error.

image

@csmoore
Copy link
Member

csmoore commented May 1, 2019

On the Pro 2.4 daily install around 4/20 the dictionary name was changed from mil2525c_b2 (that was used previously for both 2525C and 2525B) to separate dictionaries for each named mil2525c and mil2525bc2 - this change just needs updated in the code

@csmoore
Copy link
Member

csmoore commented May 6, 2019

This fix was added in PR #372

@lfunkhouser lfunkhouser added this to the 2019 JUN Sprint 7 milestone May 6, 2019
@dfoll
Copy link
Collaborator

dfoll commented May 8, 2019

I have an old version of Pro that still installs the old dictionary mil2525b_c2 so i did not see this problem until I installed @csmoore fix for this and then saw the problem ... code was looking for mil2525b or mil2525c and installed dictionary was mil2525c_b2 (essentially testing backwards of how @jmccausland found this...
i will now install a newer version of pro 2.4 that has the updated dictionary names and confirm that error is no longer displayed.

@dfoll
Copy link
Collaborator

dfoll commented May 8, 2019

Testing PR #372 I saw some weird behavior

  • installed Pro 2.4 build 19590
  • this installed a dictionary specific for 2525C
    image
  • the dictioinary for 2525B was installed as "mil2525bc2"
    image
    at this point that is not correct but it should be a problem with core 2.4, however_

image

  • when i installed mse 102 (testing branch) which should look specifically for "mil2525c" and "mil2525b" dictionaries the add-in was somehow adding the "mil2525c" and "mil2525bc2" dictionaries
    image
    image

@dfoll
Copy link
Collaborator

dfoll commented May 8, 2019

after talking to @csmoore this was just "tester error" what i was looking at in the code mil2525b is just a variable name for the dictionary that is actually named "mil2525bc2", so everything is working as expected.

dfoll added a commit that referenced this issue May 8, 2019
Change dictionary name for 2525C/B on 2.4 - #371
@dfoll
Copy link
Collaborator

dfoll commented May 9, 2019

Testing using Pro 2.4 (19590) and MSE 106 (which is the dev version built after merging #372 ).

Dictionary for 2525Bc2 or 2525C are addeded
image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants