CE-6909: functional review #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when creating materials
mistafunk
requested changes
Oct 22, 2019
There was a problem hiding this comment.
two additional issues - please investigate. if not related to this PR, please create separate issues:
- missing opacity maps on the vegetation (favela example):
- error log entries from MCHECK in PRT console when creating arnold materials on favela example:
[2019-10-22 18:39:52] [error] maya status error at /home/shaegler/esri/dev/git/serlio/src/serlio/util/MItDependencyNodesWrapper.cpp:50: (kFailure): Object does not exist (code 1)
[2019-10-22 18:39:52] [error] maya status error at /home/shaegler/esri/dev/git/serlio/src/serlio/prtMaterial/ArnoldMaterialNode.cpp:156: (kInvalidParameter): Argument is a NULL pointer (code 3)
[2019-10-22 18:39:52] [error] maya status error at /home/shaegler/esri/dev/git/serlio/src/serlio/prtMaterial/ArnoldMaterialNode.cpp:158: (kFailure): Object does not exist (code 1)
[2019-10-22 18:39:52] [error] maya status error at /home/shaegler/esri/dev/git/serlio/src/serlio/util/MItDependencyNodesWrapper.cpp:50: (kFailure): Object does not exist (code 1)
[2019-10-22 18:39:52] [error] maya status error at /home/shaegler/esri/dev/git/serlio/src/serlio/prtMaterial/ArnoldMaterialNode.cpp:156: (kInvalidParameter): Argument is a NULL pointer (code 3)
[2019-10-22 18:39:52] [error] maya status error at /home/shaegler/esri/dev/git/serlio/src/serlio/prtMaterial/ArnoldMaterialNode.cpp:158: (kFailure): Object does not exist (code 1)
[2019-10-22 18:39:52] [error] maya status error at /home/shaegler/esri/dev/git/serlio/src/serlio/util/MItDependencyNodesWrapper.cpp:50: (kFailure): Object does not exist (code 1)
|
mistafunk
approved these changes
Oct 23, 2019
Closed
|
created issue #46 for the variable shadowing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
address issues found in functional review for PR #25