-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed support for Survey123 webhooks #1386
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1386 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 145 146 +1
Lines 8053 8081 +28
Branches 1890 1890
=========================================
+ Hits 8053 8081 +28 ☔ View full report in Codecov by Sentry. |
* restores the files into the zip object. | ||
* | ||
* @param modificationCallback Function that modifies the specified files | ||
* @param zip Zip file that contains the files to modify; modified in place |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
zipObject for the param
import * as utils from "../../../common/test/mocks/utils"; | ||
import * as zipUtils from "../../src/helpers/zip-utils"; | ||
import JSZip from "jszip"; | ||
import * as zipUtilsTest from "../../../common/test/zip-utils.test";1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
trailing 1
Also some refactoring and renaming to clarify what's going on.
#1317