Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed support for Survey123 webhooks #1386

Merged
merged 4 commits into from
Feb 15, 2024
Merged

Conversation

MikeTschudi
Copy link
Member

Also some refactoring and renaming to clarify what's going on.

#1317

packages/simple-types/test/webmappingapplication.test.ts Dismissed Show dismissed Hide dismissed
packages/simple-types/test/webmappingapplication.test.ts Dismissed Show dismissed Hide dismissed
packages/simple-types/test/webmappingapplication.test.ts Dismissed Show dismissed Hide dismissed
packages/simple-types/test/webmappingapplication.test.ts Dismissed Show dismissed Hide dismissed
packages/simple-types/test/webmappingapplication.test.ts Dismissed Show dismissed Hide dismissed
packages/simple-types/test/webmappingapplication.test.ts Dismissed Show dismissed Hide dismissed
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d92c1d8) 100.00% compared to head (77d4d29) 100.00%.
Report is 3 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop     #1386   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          145       146    +1     
  Lines         8053      8081   +28     
  Branches      1890      1890           
=========================================
+ Hits          8053      8081   +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* restores the files into the zip object.
*
* @param modificationCallback Function that modifies the specified files
* @param zip Zip file that contains the files to modify; modified in place
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

zipObject for the param

import * as utils from "../../../common/test/mocks/utils";
import * as zipUtils from "../../src/helpers/zip-utils";
import JSZip from "jszip";
import * as zipUtilsTest from "../../../common/test/zip-utils.test";1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trailing 1

@MikeTschudi MikeTschudi merged commit 65b2fb0 into develop Feb 15, 2024
8 checks passed
@MikeTschudi MikeTschudi deleted the enh/1317-survey123-webhooks branch February 15, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants