Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed geography #76

Merged
merged 13 commits into from
Jun 23, 2015
Merged

Changed geography #76

merged 13 commits into from
Jun 23, 2015

Conversation

garysheppardjr
Copy link
Contributor

Moved from Afghanistan to California. This pull request will constitute a 4.1.0 release. This is a minor release, as opposed to a major release or a patch, for two reasons:

  • Functionality added (new geography)
  • Backward-compatible API changes (in military-apps-library-java)

@garysheppardjr
Copy link
Contributor Author

@csmoore, if you could take a look and comment and/or merge at your convenience, I would appreciate it. Thanks in advance.

@csmoore
Copy link
Member

csmoore commented Jun 22, 2015

Sure I will give a quick test within a few days.

@@ -39,21 +39,21 @@
<!--layer name="Bihsud Bridge and Environs" visible="true" type="LocalDynamicMapLayer" basemap="false">
<datasetpath>../../BihsudBridgeVCP.mpk</datasetpath>
</layer> -->
<layer name="COA Sketch" visible="true" type="Mil2525CMessageLayer" basemap="false">
<!--layer name="COA Sketch" visible="true" type="Mil2525CMessageLayer" basemap="false">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This COA file was a nice way to test (especially control measures) - funnily enough the version installed in the Qt SDK is over San Francisco ArcGIS SDKs\Qt10.X\sdk\samples\data\symbology if you want to use that (I can provide if you don't have Qt SDK installed - I created that version by just moving the previous VC message file to SanFran)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're focusing on Monterey, not San Francisco, so I'll make a new .xml file. It shouldn't be too hard (famous last words) using the Military Planner app.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in e4dea03

@garysheppardjr
Copy link
Contributor Author

@csmoore, I addressed the notes you entered. Please merge at your convenience unless you have found other things that need fixing.

@@ -1,124 +0,0 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are deleting these custom json files, we should also update(remove) those copy steps in the readme:
https://github.com/Esri/vehicle-commander-java/blob/master/README.md#configurecopy-the-required-files

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. That whole section in README.md is now irrelevant. I removed it in ac83f4a .

@csmoore
Copy link
Member

csmoore commented Jun 23, 2015

I like it:
image

Question: is there a geomessage simulator file somewhere I can use to test the tracks with the simulator?

@garysheppardjr
Copy link
Contributor Author

@csmoore
Copy link
Member

csmoore commented Jun 23, 2015

Thanks - everything looks good in a quick test.

image

csmoore added a commit that referenced this pull request Jun 23, 2015
@csmoore csmoore merged commit 8e591fd into Esri:master Jun 23, 2015
@garysheppardjr
Copy link
Contributor Author

Thanks!

@garysheppardjr garysheppardjr mentioned this pull request Jun 23, 2015
@jrweakland
Copy link

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants