-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed geography #76
Conversation
Moving from Afghanistan to California
Also adjusted center and scale in mapconfig.xml
@csmoore, if you could take a look and comment and/or merge at your convenience, I would appreciate it. Thanks in advance. |
Sure I will give a quick test within a few days. |
@@ -39,21 +39,21 @@ | |||
<!--layer name="Bihsud Bridge and Environs" visible="true" type="LocalDynamicMapLayer" basemap="false"> | |||
<datasetpath>../../BihsudBridgeVCP.mpk</datasetpath> | |||
</layer> --> | |||
<layer name="COA Sketch" visible="true" type="Mil2525CMessageLayer" basemap="false"> | |||
<!--layer name="COA Sketch" visible="true" type="Mil2525CMessageLayer" basemap="false"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This COA file was a nice way to test (especially control measures) - funnily enough the version installed in the Qt SDK is over San Francisco ArcGIS SDKs\Qt10.X\sdk\samples\data\symbology if you want to use that (I can provide if you don't have Qt SDK installed - I created that version by just moving the previous VC message file to SanFran)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're focusing on Monterey, not San Francisco, so I'll make a new .xml file. It shouldn't be too hard (famous last words) using the Military Planner app.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in e4dea03
@csmoore, I addressed the notes you entered. Please merge at your convenience unless you have found other things that need fixing. |
@@ -1,124 +0,0 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are deleting these custom json files, we should also update(remove) those copy steps in the readme:
https://github.com/Esri/vehicle-commander-java/blob/master/README.md#configurecopy-the-required-files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right. That whole section in README.md is now irrelevant. I removed it in ac83f4a .
Thanks! |
👍 |
Moved from Afghanistan to California. This pull request will constitute a 4.1.0 release. This is a minor release, as opposed to a major release or a patch, for two reasons: