Update runtimecore branch with jbeder/yaml-cpp master branch #8

JonLavi · 2021-09-08T09:26:37Z

I have followed this process:

Update the branch master of the fork of Esri/yaml-cpp to the current state of jbeder/yaml-cpp:

git clone git@devtopia.esri.com:3rdparty/yaml-cpp
git remote add upstream git@github.com:jbeder/yaml-cpp.git # setup the upstream remote to pull from
git fetch upstream --tags # fetch all branches and tags
git merge upstream/master
git push origin master --tags # update master and all tags

Create a branch where the changes from master are synced into runtimecore:
```
git checkout master
git pull
git checkout runtimecore
git checkout -b jon10278/update_yaml_cpp_runtimecore
git merge master 
```
Note the above conserved all the individual commits that went into jbeder/yaml-cpps master.
Built the 3rd party tooling and library for all platforms with vTest from the branch jon10278/update_yaml_cpp_runtimecore of Esri/yaml-cpp.
Run a vTest job with the custom tooling from this branch, confirming that everything builds properly and there are no regressions.
This PR: merging the branch jon10278/update_yaml_cpp_runtimecore into runtimecore, to retain any customizations we made into runtimecore, and bring in the updates from master.

…jbeder#625) - Option defaults to ON and setting it to OFF, disables install target generation

Let CMake handle the default optimizations for various configurations. We don't need to override them. In fact, overriding them makes it impossible for users to override them themselves.

* Removed an expression which is always true * The second expression (ch is space) is removed because the first one contains space 0x20 * nextEmptyLine is always false so it is removed from the expression

The issue is that numbers like 2.01 or 3.01 can not be precisely represented with binary floating point numbers. This replaces all occurrences of 'std::numeric_limits<T>::digits10 + 1' with 'std::numeric_limits<T>::max_digits10'. Background: Using 'std::numeric_limits<T>::digits10 + 1' is not precise enough. Converting a 'float' into a 'string' and back to a 'float' will not always produce the original 'float' value. To guarantee that the 'string' representation has sufficient precision the value 'std::numeric_limits<T>::max_digits10' has to be used.

Splitting the condition of the if statement containing `constant expression` eliminates warnings in Visual Studio with /W4.

NDK now uses ninja for building but yaml-cpp would emit the “ninja: error: build.ninja:326: bad $-escape (literal $ must be written as $$)” error due to syntax error in the generated build.ninja file. Related issue: jbeder#630

ref jbeder#110

… for g++ and clang++ (jbeder#686) * Add compilation flags: -Wshadow -Weffc++ -pedantic -pedantic-errors * Delete implicit copy & move constructors & assignment operators in classes with pointer data members. * An exception to the above: Add default copy & move constructors & assignment operators for the Binary class. * Convert boolean RegEx operators to binary operators. * Initialize all members in all classes in ctors. * Let default ctor delegate to the converting ctor in Binary and RegEx * Don't change any tests except regex_test (as a result of the change to binary operators). Note: https://bugzilla.redhat.com/show_bug.cgi?id=1544675 makes -Weffc++ report a false positive in "include/yaml-cpp/node/impl.h".

It wouldn't have compiled anyways, since the Scanner and Directive objects inside it are incomplete types at the time of the move definitions.

Invalid access via operator[] or as<> will now print the offending key, if possible. For example: a: x: 1 y: 2 node["a"]["z"].as<int>() will say that the key "z" was invalid.

…latforms (jbeder#717) Specifically, printing `.nan`, `.inf`, and `-.inf`, respectively, as per the spec section 10.2.1.4.

This sets the other variables: https://cmake.org/cmake/help/latest/command/project.html

…der#735) Setting CMAKE_CXX_STANDARD and CMAKE_CXX_STANDARD_REQUIRED directly is problematic when including yaml-cpp as a subproject. The proper way is to set these per-target.

…beder#734) * CMake: Prefix options with "YAML" and hide platform-specific options When including yaml-cpp as a subproject, some option names can conflict with other projects. (1) Make sure the yaml-cpp options are prefixed with YAML (2) Hide platform-specific options when possible to avoid cluttering the cmake option list * Update docs for change from BUILD_SHARED_LIBS to YAML_BUILD_SHARED_LIBS

Remove 2.6-isms Remove 2.8-isms Bump CMake minimum version to 3.4 Disable some options when used as a subdirectory Use `CONFIGURE_DEPENDS` with `file(GLOB)` when possible Backport CMake 3.15's MSVC_RUNTIME_LIBRARY setting. Set all compile options as generator expressions. Set all find-package files to be installed to the correct file. Remove `export(PACKAGE)`, as this has been deprecated. Remove fat binary support Remove manual setting of iPhone settings. These should be set by parent projects. Remove use of ExternalProject for a local use Conditionally remove format target unless clang-format is found

Example of how someone might consume yaml-cpp with bazel: cc_binary( name = "example", srcs = ["example.cc"], deps = ["@com_github_jbeder_yaml_cpp//:yaml-cpp"], )

The generator expressions here are actually unnecessary, now that I think about it. This should fix jbeder#745

…r#751)

…der#753)

…rator (jbeder#755)

Fixes jbeder#740.

…ttings. (jbeder#915)

Per https://cmake.org/cmake/help/latest/policy/CMP0091.html, we need to enable policy CMP0091 if we want to make use of MSVC_RUNTIME_LIBRARY and/or CMAKE_MSVC_RUNTIME_LIBRARY. Fixes issue jbeder#912.

For completeness I've implemented escaping for characters outside the basic multilingual plane, but it doesn't get used (as there's no EscapeAsAsciiJson emitter option implemented).

Not use 'emit' as variable name, in Qt Framework it reserved word

Fixes jbeder#590.

Fixes jbeder#501

Fixes jbeder#917

- Don't eagerly convert key to std::string - Make const char* keys streamable when exception is thrown - Don't create a temporary string when comparing a const char* key

…ng emitting. (jbeder#921) * fix issue743: handle the empty content of flow sep/map correctly during emitting. * handle the empty Tag/Anchor properly. * delete comment

convert.h line130 : warning C4244 conversation from int to T possible loss of data

Removed the variable name in the defaulted function to make GCC happy.

…arnings. (jbeder#1012)

…l_cpp_runtimecore

duncanthomson · 2021-09-08T15:19:56Z

One small nitpick here: I think /bazel-* got removed unnecessarily from the gitignore file when you resolved conflicts.

JonLavi · 2021-09-08T15:28:55Z

Well spotted @duncanthomson ! I've fixed that just now.

kukkamario and others added 30 commits November 18, 2018 11:27

Add YAML_CPP_INSTALL option for disabling install target (jbeder#624) (…

54fc4da

…jbeder#625) - Option defaults to ON and setting it to OFF, disables install target generation

Don't stomp on build flags (jbeder#635)

2443da5

Let CMake handle the default optimizations for various configurations. We don't need to override them. In fact, overriding them makes it impossible for users to override them themselves.

Some small changes as a result of using a static analyzer (jbeder#643)

b659858

* Removed an expression which is always true * The second expression (ch is space) is removed because the first one contains space 0x20 * nextEmptyLine is always false so it is removed from the expression

Fix GCC-types flags appended on Clang-cl (jbeder#659)

b87c76a

Fix warning C4127 on Visual Studio (jbeder#672)

283d06f

Splitting the condition of the if statement containing `constant expression` eliminates warnings in Visual Studio with /W4.

Fix ninja build error. (jbeder#677)

a2a113c

NDK now uses ninja for building but yaml-cpp would emit the “ninja: error: build.ninja:326: bad $-escape (literal $ must be written as $$)” error due to syntax error in the generated build.ninja file. Related issue: jbeder#630

Add optional OnAnchor method to EventHandler (jbeder#530)

eca9cfd

ref jbeder#110

Add MSVC Debugger Visualizer config for YAML::Node (jbeder#693)

82e9571

Disallow moving for the Parser.

bd7f8c6

It wouldn't have compiled anyways, since the Scanner and Directive objects inside it are incomplete types at the time of the move definitions.

Improve error messages on operator[] or as<> (jbeder#656)

0122697

Invalid access via operator[] or as<> will now print the offending key, if possible. For example: a: x: 1 y: 2 node["a"]["z"].as<int>() will say that the key "z" was invalid.

Make sure output of NaN, Infinity and -Infinity is identical on all p…

e0e01d5

…latforms (jbeder#717) Specifically, printing `.nan`, `.inf`, and `-.inf`, respectively, as per the spec section 10.2.1.4.

Use VERSION on the CMake project (jbeder#733)

9035066

This sets the other variables: https://cmake.org/cmake/help/latest/command/project.html

Set C++ standard options in CMake per-target instead of globally (jbe…

d638508

…der#735) Setting CMAKE_CXX_STANDARD and CMAKE_CXX_STANDARD_REQUIRED directly is problematic when including yaml-cpp as a subproject. The proper way is to set these per-target.

Static analysis fix: replace 0 and NULL with nullptr (jbeder#738)

db0bda7

Remove extraneous conversion from string -> c_str -> string (jbeder#739)

b218787

Fix shared lib build with new YAML_BUILD_SHARED_LIBS option (jbeder#737)

968e0c1

Update version to 0.6.3.

9a36242

Add bazel Support (jbeder#724)

62ff351

Example of how someone might consume yaml-cpp with bazel: cc_binary( name = "example", srcs = ["example.cc"], deps = ["@com_github_jbeder_yaml_cpp//:yaml-cpp"], )

Fix DEBUG_POSTFIX property (jbeder#746)

9d7e556

The generator expressions here are actually unnecessary, now that I think about it. This should fix jbeder#745

CMake: Remove unused option YAML_APPLE_UNIVERSAL_BIN (jbeder#744)

47d32aa

Use cassert instead of old assert.h (jbeder#750)

e6b3a92

Modernize: Use "default" for destructors and copy constructors (jbede…

a6ed66a

…r#751)

Pass std::string by const ref (jbeder#749)

99d95d8

Modernization: Use "override" when overriding base class methods (jbe…

0fddd1e

…der#753)

Modernize: Use "using" instead of "typedef" (jbeder#754)

6e87b37

Replace node's YAML_CPP_OPERATOR_BOOL macro with an explicit bool ope…

8480911

…rator (jbeder#755)

dota17 and others added 23 commits July 2, 2020 14:08

Parse colon in plain scalar correctly when in a flow collection

026a53f

Fixes jbeder#740.

fix bug from issue298:Emitter stylings settings overridden by node se…

6d5cfab

…ttings. (jbeder#915)

Enable CMP0091 to use MSVC_RUNTIME_LIBRARY (jbeder#913)

370acee

Per https://cmake.org/cmake/help/latest/policy/CMP0091.html, we need to enable policy CMP0091 if we want to make use of MSVC_RUNTIME_LIBRARY and/or CMAKE_MSVC_RUNTIME_LIBRARY. Fixes issue jbeder#912.

Add support for JSON-compatible string escapes (jbeder#485)

c82d312

For completeness I've implemented escaping for characters outside the basic multilingual plane, but it doesn't get used (as there's no EscapeAsAsciiJson emitter option implemented).

Fix compilation for Qt-projects (jbeder#918)

4571e81

Not use 'emit' as variable name, in Qt Framework it reserved word

Add the support to parsing a null value as std::string.

3331528

Fixes jbeder#590.

Handle a key with length over 1024 as a long key. (jbeder#916)

51ce663

Fixes jbeder#501

Properly allow a trailing tab character on a block scalar (jbeder#919)

c3df6d8

Fixes jbeder#917

Default initialize node's member variable (jbeder#923)

06b99f5

Reduce std::string copies (jbeder#924)

bc9874c

- Don't eagerly convert key to std::string - Make const char* keys streamable when exception is thrown - Don't create a temporary string when comparing a const char* key

Fix runtime exceptions in Visual Studio environment. (jbeder#926)

c2793a3

Add the AppVeyor configuration file (jbeder#927)

11917ba

fix issue743: handle the empty content of flow sep/map correctly duri…

1c9abc8

…ng emitting. (jbeder#921) * fix issue743: handle the empty content of flow sep/map correctly during emitting. * handle the empty Tag/Anchor properly. * delete comment

Emit the correct Alias on the key (jbeder#908) (jbeder#929)

98acc5a

fix warning of level 4: (jbeder#971)

a6bbe0e

convert.h line130 : warning C4244 conversation from int to T possible loss of data

Prevent trailing spaces when emitting literal strings (jbeder#1005)

9ee3928

Update version to 0.7.0.

0579ae3

Update node impl.h for GCC unused variable warning (jbeder#981)

b591d8a

Removed the variable name in the defaulted function to make GCC happy.

Bump minimum cmake versions in gtest to eliminate cmake deprecation w…

ef0bba1

…arnings. (jbeder#1012)

Add assert to enable compilation with libcxx + gcc (jbeder#947)

79aa6d5

Include name of anchor in invalid anchor error (jbeder#1015)

db6deed

Added UE-Wrapper link to Readme (jbeder#1024)

6308112

Merge remote-tracking branch 'origin/master' into jon10278/update_yam…

433b516

…l_cpp_runtimecore

JonLavi requested a review from duncanthomson September 8, 2021 13:31

JonLavi marked this pull request as ready for review September 8, 2021 14:17

duncanthomson approved these changes Sep 8, 2021

View reviewed changes

fixup: restore entry to gitignore

106db7e

JonLavi merged commit 8cd0385 into runtimecore Sep 8, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update runtimecore branch with jbeder/yaml-cpp master branch #8

Update runtimecore branch with jbeder/yaml-cpp master branch #8

JonLavi commented Sep 8, 2021

duncanthomson commented Sep 8, 2021

JonLavi commented Sep 8, 2021

Update runtimecore branch with jbeder/yaml-cpp master branch #8

Update runtimecore branch with jbeder/yaml-cpp master branch #8

Conversation

JonLavi commented Sep 8, 2021

duncanthomson commented Sep 8, 2021

JonLavi commented Sep 8, 2021