Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Console" title in locale file #2756

Closed
Lammendam opened this issue Aug 21, 2019 · 2 comments · Fixed by #3700
Closed

"Console" title in locale file #2756

Lammendam opened this issue Aug 21, 2019 · 2 comments · Fixed by #3700
Labels
status: open to PR Low priority enhancements that anyone is welcome to contribute. type: enhancement Features and feature requests.
Milestone
2.19.0

Comments

@Lammendam
Copy link

Feature request

Feature description
Put "Console" string to locale file. This is that "Console" that appears to player when he receive PM from console.

How the feature is useful
This is useful when staff want to say something to the player on behalf of the console. For example, notify the player of some important event but also want to customize Console name to more friendly and interesting name.
@darbyjack
Copy link
Member

PR opened #2758

@darbyjack darbyjack self-assigned this Aug 21, 2019
@darbyjack darbyjack added status: open to PR Low priority enhancements that anyone is welcome to contribute. type: enhancement Features and feature requests. labels Aug 21, 2019
@pop4959
Copy link
Member

pop4959 commented Apr 30, 2020

@darbyjack Still planning to give this a shot? If not, maybe unassign yourself from this.

@Haarolean Haarolean mentioned this issue Oct 3, 2020
Merged
@mdcfe mdcfe added this to the 2.19.0 milestone Dec 11, 2020
mdcfe pushed a commit that referenced this issue Dec 11, 2020
@Haarolean
Allow console name to be translated (#3700)
450da59 
Co-authored-by: Josh Roy <10731363+JRoy@users.noreply.github.com>

Closes #2756. 

Notes:
- I've kept original name for internal purposes (storing bans, etc), just in case user wants to rename it to something unbearable;
- User can message console via both names (since he can try both, duh);
- Some refactoring. Just a little.
DarkEyeDragon pushed a commit to DarkEyeDragon/Essentials that referenced this issue Dec 24, 2020
@Haarolean @DarkEyeDragon
Allow console name to be translated (EssentialsX#3700)
d65498a 
Co-authored-by: Josh Roy <10731363+JRoy@users.noreply.github.com>

Closes EssentialsX#2756. 

Notes:
- I've kept original name for internal purposes (storing bans, etc), just in case user wants to rename it to something unbearable;
- User can message console via both names (since he can try both, duh);
- Some refactoring. Just a little.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: open to PR Low priority enhancements that anyone is welcome to contribute. type: enhancement Features and feature requests.
Projects
None yet
Milestone
2.19.0
Development

Successfully merging a pull request may close this issue.

Allow console name to be translated Haarolean/Essentials
4 participants
@mdcfe @pop4959 @darbyjack @Lammendam